From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <catalin.marinas@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <penberg@cs.helsinki.fi>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 1/5] kmemleak: use bool for true/false questions
Date: Wed, 2 Sep 2009 18:40:55 -0700 [thread overview]
Message-ID: <1251942059-21448-2-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1251942059-21448-1-git-send-email-lrodriguez@atheros.com>
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
mm/kmemleak.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 4872673..c6e71bb 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -264,17 +264,17 @@ static void kmemleak_disable(void);
* Newly created objects don't have any color assigned (object->count == -1)
* before the next memory scan when they become white.
*/
-static int color_white(const struct kmemleak_object *object)
+static bool color_white(const struct kmemleak_object *object)
{
return object->count != -1 && object->count < object->min_count;
}
-static int color_gray(const struct kmemleak_object *object)
+static bool color_gray(const struct kmemleak_object *object)
{
return object->min_count != -1 && object->count >= object->min_count;
}
-static int color_black(const struct kmemleak_object *object)
+static bool color_black(const struct kmemleak_object *object)
{
return object->min_count == -1;
}
@@ -284,7 +284,7 @@ static int color_black(const struct kmemleak_object *object)
* not be deleted and have a minimum age to avoid false positives caused by
* pointers temporarily stored in CPU registers.
*/
-static int unreferenced_object(struct kmemleak_object *object)
+static bool unreferenced_object(struct kmemleak_object *object)
{
return (object->flags & OBJECT_ALLOCATED) && color_white(object) &&
time_before_eq(object->jiffies + jiffies_min_age,
--
1.6.3.3
next prev parent reply other threads:[~2009-09-03 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 1:40 [PATCH 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-03 1:40 ` Luis R. Rodriguez [this message]
2009-09-03 6:02 ` [PATCH 1/5] kmemleak: use bool for true/false questions Pekka Enberg
2009-09-03 1:40 ` [PATCH 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-03 1:40 ` [PATCH 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-03 6:03 ` Pekka Enberg
2009-09-03 1:40 ` [PATCH 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-03 6:16 ` Pekka Enberg
2009-09-03 1:40 ` [PATCH 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-03 6:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251942059-21448-2-git-send-email-lrodriguez@atheros.com \
--to=lrodriguez@atheros.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®