From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: <catalin.marinas@arm.com>
Cc: <linux-kernel@vger.kernel.org>, <penberg@cs.helsinki.fi>,
"Luis R. Rodriguez" <lrodriguez@atheros.com>
Subject: [PATCH 4/5] kmemleak: fix sparse warning over overshadowed flags
Date: Wed, 2 Sep 2009 18:40:58 -0700 [thread overview]
Message-ID: <1251942059-21448-5-git-send-email-lrodriguez@atheros.com> (raw)
In-Reply-To: <1251942059-21448-1-git-send-email-lrodriguez@atheros.com>
This fixes this sparse warning:
mm/kmemleak.c:512:31: warning: symbol 'flags' shadows an earlier one
mm/kmemleak.c:448:23: originally declared here
Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
---
mm/kmemleak.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mm/kmemleak.c b/mm/kmemleak.c
index 7bb1d48..09ddf9c 100644
--- a/mm/kmemleak.c
+++ b/mm/kmemleak.c
@@ -509,14 +509,14 @@ static void create_object(unsigned long ptr, size_t size, int min_count,
* random memory blocks.
*/
if (node != &object->tree_node) {
- unsigned long flags;
+ unsigned long flags_object;
kmemleak_stop("Cannot insert 0x%lx into the object search tree "
"(already existing)\n", ptr);
object = lookup_object(ptr, 1);
- spin_lock_irqsave(&object->lock, flags);
+ spin_lock_irqsave(&object->lock, flags_object);
dump_object_info(object);
- spin_unlock_irqrestore(&object->lock, flags);
+ spin_unlock_irqrestore(&object->lock, flags_object);
goto out;
}
--
1.6.3.3
next prev parent reply other threads:[~2009-09-03 1:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 1:40 [PATCH 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-03 1:40 ` [PATCH 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-03 6:02 ` Pekka Enberg
2009-09-03 1:40 ` [PATCH 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-03 1:40 ` [PATCH 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-03 6:03 ` Pekka Enberg
2009-09-03 1:40 ` Luis R. Rodriguez [this message]
2009-09-03 6:16 ` [PATCH 4/5] kmemleak: fix sparse warning over overshadowed flags Pekka Enberg
2009-09-03 1:40 ` [PATCH 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-03 6:17 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251942059-21448-5-git-send-email-lrodriguez@atheros.com \
--to=lrodriguez@atheros.com \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®