mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Miklos Szeredi <mszeredi@suse.cz>
To: Valdis.Kletnieks@vt.edu
Cc: Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	miklos@szeredi.hu, Andrew Morton <akpm@linux-foundation.org>,
	Matthew Wilcox <matthew@wil.cx>,
	Andreas Gruenbacher <agruen@suse.de>,
	Al Viro <viro@zeniv.linux.org.uk>, Christoph Hellwig <hch@lst.de>,
	linux-kernel@vger.kernel.org
Subject: Re: vfs-fix-d_path-for-unreachable-paths.patch
Date: Mon, 07 Sep 2009 10:30:54 +0200	[thread overview]
Message-ID: <1252312254.4733.12.camel@tucsk> (raw)
In-Reply-To: <2818.1252160549@turing-police.cc.vt.edu>

On Sat, 2009-09-05 at 10:22 -0400, Valdis.Kletnieks@vt.edu wrote:
> Somebody is buggy here, but I'm not sure who. The initrd for leaving a dangling
> reference, the patch for breaking /proc/mounts, or /sbin/restorecon and the
> shutdown script for being far too trusting of what the kernel tells it?
> 

Hugh Dickins reported a similar issue, where gnome-vfs chokes on
that /proc/mounts line as well.

I think the conclusion is that this change in /proc/mounts is not going
to work.  There are two solutions:

 1) leave out unreachable mounts from /proc/PID/mounts altogether
 2) completely revert /proc/PID/mounts to the old behavior

The first option is much less likely to break something than the current
patch, but it's still an ABI change.

So I think it's better to go with the second option.  Patches coming
up...

Thanks,
Miklos



  reply	other threads:[~2009-09-07  8:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05 14:22 vfs-fix-d_path-for-unreachable-paths.patch Valdis.Kletnieks
2009-09-07  8:30 ` Miklos Szeredi [this message]
2009-09-07  8:38   ` [patch 1/2] vfs: seq_file: add helpers for data filling Miklos Szeredi
2009-09-07  8:41     ` [patch 2/2] vfs: revert /proc/mounts to old behavior for unreachable mountpoints Miklos Szeredi
2009-09-09 21:15     ` [patch 1/2] vfs: seq_file: add helpers for data filling Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252312254.4733.12.camel@tucsk \
    --to=mszeredi@suse.cz \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=agruen@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=miklos@szeredi.hu \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome