* linux-next: scsi-post-merge tree build failure
@ 2009-09-07 10:06 Stephen Rothwell
2009-09-08 8:12 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2009-09-07 10:06 UTC (permalink / raw)
To: James Bottomley
Cc: linux-next, linux-kernel, Jayamohan Kallickal, Mike Christie
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
Hi James,
Today's linux-next build (powerpc allyesconfig) failed like this:
drivers/scsi/be2iscsi/be_main.c: In function 'hwi_write_buffer':
drivers/scsi/be2iscsi/be_main.c:1481: error: implicit declaration of function 'virt_to_bus'
Caused by commit 9316dc3deb9675c674f96a0c6fb74ccc6c497fae ("[SCSI]
be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver") which I have reverted
for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: scsi-post-merge tree build failure
2009-09-07 10:06 linux-next: scsi-post-merge tree build failure Stephen Rothwell
@ 2009-09-08 8:12 ` Stephen Rothwell
2009-09-08 15:48 ` James Bottomley
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Rothwell @ 2009-09-08 8:12 UTC (permalink / raw)
To: James Bottomley
Cc: linux-next, linux-kernel, Jayamohan Kallickal, Mike Christie
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
Hi James,
On Mon, 7 Sep 2009 20:06:46 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Today's linux-next build (powerpc allyesconfig) failed like this:
>
> drivers/scsi/be2iscsi/be_main.c: In function 'hwi_write_buffer':
> drivers/scsi/be2iscsi/be_main.c:1481: error: implicit declaration of function 'virt_to_bus'
>
> Caused by commit 9316dc3deb9675c674f96a0c6fb74ccc6c497fae ("[SCSI]
> be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver") which I have reverted
> for today.
The driver needs to depend on CONFIG_VIRT_TO_BUS if it needs to use
virt_to_bus(). That will prevent it from building on some platforms
(like powerpc) that do not implement virt_to_bus() and its brothers.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: linux-next: scsi-post-merge tree build failure
2009-09-08 8:12 ` Stephen Rothwell
@ 2009-09-08 15:48 ` James Bottomley
0 siblings, 0 replies; 3+ messages in thread
From: James Bottomley @ 2009-09-08 15:48 UTC (permalink / raw)
To: Stephen Rothwell
Cc: linux-next, linux-kernel, Jayamohan Kallickal, Mike Christie, linux-scsi
On Tue, 2009-09-08 at 18:12 +1000, Stephen Rothwell wrote:
> Hi James,
>
> On Mon, 7 Sep 2009 20:06:46 +1000 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> >
> > Today's linux-next build (powerpc allyesconfig) failed like this:
> >
> > drivers/scsi/be2iscsi/be_main.c: In function 'hwi_write_buffer':
> > drivers/scsi/be2iscsi/be_main.c:1481: error: implicit declaration of function 'virt_to_bus'
> >
> > Caused by commit 9316dc3deb9675c674f96a0c6fb74ccc6c497fae ("[SCSI]
> > be2iscsi: add 10Gbps iSCSI - BladeEngine 2 driver") which I have reverted
> > for today.
>
> The driver needs to depend on CONFIG_VIRT_TO_BUS if it needs to use
> virt_to_bus(). That will prevent it from building on some platforms
> (like powerpc) that do not implement virt_to_bus() and its brothers.
Actually, this is a modern hardware iSCSI card not some legacy piece of
hardware: it needs to use the proper API for this.
James
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-09-08 15:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-07 10:06 linux-next: scsi-post-merge tree build failure Stephen Rothwell
2009-09-08 8:12 ` Stephen Rothwell
2009-09-08 15:48 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®