From: Frederic Weisbecker <fweisbec@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: LKML <linux-kernel@vger.kernel.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Prasad <prasad@linux.vnet.ibm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Jan Kiszka <jan.kiszka@siemens.com>,
Jiri Slaby <jirislaby@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
Avi Kivity <avi@redhat.com>, Paul Mackerras <paulus@samba.org>,
Mike Galbraith <efault@gmx.de>,
Masami Hiramatsu <mhiramat@redhat.com>
Subject: [PATCH 1/5] perf_counter: Add open/close pmu callbacks
Date: Thu, 10 Sep 2009 10:29:23 +0200 [thread overview]
Message-ID: <1252571367-25876-2-git-send-email-fweisbec@gmail.com> (raw)
In-Reply-To: <1252571367-25876-1-git-send-email-fweisbec@gmail.com>
Add the open() and close() callback to the pmu structure.
Open is called when a counter is initialized just after it's allocation
and close is called when the counter is about to be released.
These callbacks are useful for example when a pmu has to deal with
several registers and needs to maintain an internal list of counters
using them. Given such list, the pmu is able to check if the the number
of physical registers are still sufficient for the new created counter
and then accept or refuse this counter.
open() will return 0 in case of success or an error if we have not
enough registers for the given counter (or whatever error a pmu may
encounter).
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Prasad <prasad@linux.vnet.ibm.com>
Cc: Alan Stern <stern@rowland.harvard.edu>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Jiri Slaby <jirislaby@gmail.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>
Cc: Avi Kivity <avi@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Masami Hiramatsu <mhiramat@redhat.com>
---
include/linux/perf_counter.h | 3 +++
kernel/perf_counter.c | 27 +++++++++++++++++++++------
2 files changed, 24 insertions(+), 6 deletions(-)
diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index 9ba1822..f557483 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -487,6 +487,8 @@ struct pmu {
void (*disable) (struct perf_counter *counter);
void (*read) (struct perf_counter *counter);
void (*unthrottle) (struct perf_counter *counter);
+ int (*open) (struct perf_counter *counter);
+ void (*close) (struct perf_counter *counter);
};
/**
@@ -497,6 +499,7 @@ enum perf_counter_active_state {
PERF_COUNTER_STATE_OFF = -1,
PERF_COUNTER_STATE_INACTIVE = 0,
PERF_COUNTER_STATE_ACTIVE = 1,
+ PERF_COUNTER_STATE_UNOPENED = 2,
};
struct file;
diff --git a/kernel/perf_counter.c b/kernel/perf_counter.c
index d7cbc57..400ccf6 100644
--- a/kernel/perf_counter.c
+++ b/kernel/perf_counter.c
@@ -1675,6 +1675,10 @@ static void free_counter(struct perf_counter *counter)
atomic_dec(&nr_task_counters);
}
+ if (counter->pmu->close)
+ if (counter->state != PERF_COUNTER_STATE_UNOPENED)
+ counter->pmu->close(counter);
+
if (counter->destroy)
counter->destroy(counter);
@@ -4101,15 +4105,19 @@ done:
else if (IS_ERR(pmu))
err = PTR_ERR(pmu);
- if (err) {
- if (counter->ns)
- put_pid_ns(counter->ns);
- kfree(counter);
- return ERR_PTR(err);
- }
+ if (err)
+ goto fail;
counter->pmu = pmu;
+ if (pmu->open) {
+ err = pmu->open(counter);
+ if (err) {
+ counter->state = PERF_COUNTER_STATE_UNOPENED;
+ goto fail;
+ }
+ }
+
if (!counter->parent) {
atomic_inc(&nr_counters);
if (counter->attr.mmap)
@@ -4121,6 +4129,13 @@ done:
}
return counter;
+
+fail:
+ if (counter->ns)
+ put_pid_ns(counter->ns);
+ kfree(counter);
+
+ return ERR_PTR(err);
}
static int perf_copy_attr(struct perf_counter_attr __user *uattr,
--
1.6.2.3
next prev parent reply other threads:[~2009-09-10 8:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 8:29 [RFC GIT PULL] hw-breakpoints: Rewrite on top of perf counters Frederic Weisbecker
2009-09-10 8:29 ` Frederic Weisbecker [this message]
2009-09-10 11:22 ` [PATCH 1/5] perf_counter: Add open/close pmu callbacks Paul Mackerras
2009-09-10 18:46 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 2/5] perf_counter: Export various perf helpers for external users Frederic Weisbecker
2009-09-10 11:28 ` Paul Mackerras
2009-09-10 18:43 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 3/5] hw-breakpoints: Rewrite the hw-breakpoints layer on top of perf counters Frederic Weisbecker
2009-09-10 14:25 ` K.Prasad
2009-09-10 18:53 ` Frederic Weisbecker
2009-09-10 21:18 ` Peter Zijlstra
2009-09-14 21:18 ` Frederic Weisbecker
2009-09-14 17:17 ` K.Prasad
2009-09-14 21:33 ` Frederic Weisbecker
2009-09-11 22:09 ` Jan Kiszka
2009-09-14 3:41 ` Frederic Weisbecker
2009-09-14 6:24 ` Jan Kiszka
2009-09-14 18:01 ` Frederic Weisbecker
2009-09-14 17:28 ` K.Prasad
2009-09-14 21:36 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 4/5] hw-breakpoints: Arbitrate access to pmu following registers constraints Frederic Weisbecker
2009-09-10 14:41 ` Daniel Walker
2009-09-10 14:57 ` Peter Zijlstra
2009-09-10 14:59 ` Daniel Walker
2009-09-10 15:02 ` Steven Rostedt
2009-09-10 18:53 ` Frederic Weisbecker
2009-09-10 8:29 ` [PATCH 5/5] ksym_tracer: Remove KSYM_SELFTEST_ENTRY Frederic Weisbecker
2009-09-10 10:09 ` [RFC GIT PULL] hw-breakpoints: Rewrite on top of perf counters Paul Mackerras
2009-09-10 17:23 ` Ingo Molnar
2009-09-10 18:24 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252571367-25876-2-git-send-email-fweisbec@gmail.com \
--to=fweisbec@gmail.com \
--cc=acme@redhat.com \
--cc=avi@redhat.com \
--cc=efault@gmx.de \
--cc=jan.kiszka@siemens.com \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mhiramat@redhat.com \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome