mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Corentin Chary <corentincj@iksaif.net>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Julia Lawall <julia@diku.dk>,
	Alan Jenkins <alan-jenkins@tuffmail.co.uk>,
	Johannes Berg <johannes@sipsolutions.net>,
	Corentin Chary <corentincj@iksaif.net>
Subject: [PATCH 1/3] hp-wmi: fix rfkill memory leak on unload
Date: Mon, 14 Sep 2009 12:43:51 +0200	[thread overview]
Message-ID: <1252925033-29696-2-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1252925033-29696-1-git-send-email-corentincj@iksaif.net>

rfkill_unregister() should always be followed by rfkill_destroy()
In this case, rfkill_destroy was called two times on wifi_rfkill and
never on bluetooth_rfkill.

Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
 drivers/platform/x86/hp-wmi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c
index a2ad53e..a750192 100644
--- a/drivers/platform/x86/hp-wmi.c
+++ b/drivers/platform/x86/hp-wmi.c
@@ -502,7 +502,7 @@ static int __exit hp_wmi_bios_remove(struct platform_device *device)
 	}
 	if (bluetooth_rfkill) {
 		rfkill_unregister(bluetooth_rfkill);
-		rfkill_destroy(wifi_rfkill);
+		rfkill_destroy(bluetooth_rfkill);
 	}
 	if (wwan_rfkill) {
 		rfkill_unregister(wwan_rfkill);
-- 
1.6.4.2


  reply	other threads:[~2009-09-14 10:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-14 10:43 [PATCH 0/3] rfkill_unregister() should always be followed by rfkill_destroy() Corentin Chary
2009-09-14 10:43 ` Corentin Chary [this message]
2009-09-14 10:43   ` [PATCH 2/3] thinkpad_acpi: fix rfkill memory leak on unload Corentin Chary
2009-09-14 10:43     ` [PATCH 3/3] dell-laptop: " Corentin Chary
2009-09-14 10:46       ` Matthew Garrett
2009-09-14 11:02         ` Alan Jenkins
2009-09-14 12:01           ` Corentin Chary
2009-09-14 13:22     ` [PATCH 2/3] thinkpad_acpi: " Henrique de Moraes Holschuh
2009-09-19  5:10     ` Len Brown
2009-09-14 10:59   ` [PATCH 1/3] hp-wmi: " Matthew Garrett
2009-09-19  5:13     ` Len Brown
2009-09-14 13:24 ` [PATCH 0/3] rfkill_unregister() should always be followed by rfkill_destroy() Henrique de Moraes Holschuh
2009-09-14 14:57   ` Alan Jenkins
2009-09-14 17:07     ` Henrique de Moraes Holschuh
2009-09-14 17:10       ` Henrique de Moraes Holschuh
2009-09-14 17:47         ` Corentin Chary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252925033-29696-2-git-send-email-corentincj@iksaif.net \
    --to=corentincj@iksaif.net \
    --cc=alan-jenkins@tuffmail.co.uk \
    --cc=johannes@sipsolutions.net \
    --cc=julia@diku.dk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®