Re: [PATCH 0/3] rfkill_unregister() should always be followed by rfkill_destroy()

[Henrique de Moraes Holschuh <hmh@hmh.eng.br>]

On Mon, 14 Sep 2009, Alan Jenkins wrote:
> Henrique de Moraes Holschuh wrote:
> > On Mon, 14 Sep 2009, Corentin Chary wrote:
> >   
> >>  drivers/platform/x86/dell-laptop.c   |   36 ++++++++++++++++++++++-----------
> >>  drivers/platform/x86/hp-wmi.c        |    2 +-
> >>  drivers/platform/x86/thinkpad_acpi.c |    1 +
> >>     
> >
> > These are also likely needed in 2.6.31, please add appropriate Cc: lines to
> > stable@kernel.org while adding the Acked-By's.
> 
> Do they meet the -stable criteria?

The ones for thinkpad_acpi and hp-wmi do (fix obvious bug, small and
obviously correct, impossible to cause regressions).

I don't know about the fix for dell-laptop since it is a lot larger.

>  - It must fix a real bug that bothers people (not a, "This could be a
>    problem..." type thing).

Memory leaks are real bugs, especially these ones that _always_ happen and
are not even on the error paths, but on the main code path...

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh