From: Andrew Davis <afd@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ
Date: Mon, 19 May 2025 21:28:45 -0500 [thread overview]
Message-ID: <125293c8-c5a6-4fa8-bf5c-4da8d2fbf510@ti.com> (raw)
In-Reply-To: <5340db48-f7cb-4c81-ae2b-2fdd31694416@sirena.org.uk>
On 5/19/25 5:12 AM, Mark Brown wrote:
> On Fri, May 16, 2025 at 09:17:22AM -0500, Andrew Davis wrote:
>> If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
>> This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
>> based on the above two symbols respectively. This makes it very easy
>> to end up with "circular dependencies".
>>
>> Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
>> use of them. This is almost equivalent to before but makes it less
>> likely to end up with false circular dependency detections.
>
> None of these selects should actually do anything since the symbols are
> themselves selected?
I was thinking the same, but turns out (and I had to check to prove it to
myself) that "select" actually follows up the dependency tree. So unlike
"depends on" which is weird(broken), "select" functions in a sane way.
Andrew
next prev parent reply other threads:[~2025-05-20 2:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 14:17 Andrew Davis
2025-05-18 12:25 ` Krzysztof Kozlowski
2025-05-19 10:12 ` Mark Brown
2025-05-20 2:28 ` Andrew Davis [this message]
2025-05-21 15:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=125293c8-c5a6-4fa8-bf5c-4da8d2fbf510@ti.com \
--to=afd@ti.com \
--cc=broonie@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®