From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andrew Davis <afd@ti.com>, Mark Brown <broonie@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] regmap: Move selecting for REGMAP_MDIO and REGMAP_IRQ
Date: Sun, 18 May 2025 14:25:24 +0200 [thread overview]
Message-ID: <efdfa6fe-2d9f-4c68-93db-08df05af6922@linaro.org> (raw)
In-Reply-To: <20250516141722.13772-1-afd@ti.com>
On 16/05/2025 16:17, Andrew Davis wrote:
> If either REGMAP_IRQ or REGMAP_MDIO are set then REGMAP is also set.
> This then enables the selecting of IRQ_DOMAIN or MDIO_BUS from REGMAP
> based on the above two symbols respectively. This makes it very easy
> to end up with "circular dependencies".
>
> Instead select the IRQ_DOMAIN or MDIO_BUS from the symbols that make
> use of them. This is almost equivalent to before but makes it less
> likely to end up with false circular dependency detections.
>
> Signed-off-by: Andrew Davis <afd@ti.com>
> ---
>
> Sending as RFC as I haven't tested all the possible permutations
> on config options right now to make sure this causes no changes,
> but wanted to suggest this as a possible solution to the circular
> dependency described here[0].
Reported-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Closes: https://lore.kernel.org/r/bfe991fa-f54c-4d58-b2e0-34c4e4eb48f4@linaro.org/
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Looks ok and seems to solve issues I saw.
This is a potential dependency for a mux patch I want to send to Greg
for upcoming merge window, so it would be great if this was marked as fixes
and got to current RC. Or optionally I could take it with mentioned
mux patch:
https://lore.kernel.org/all/20250515140555.325601-2-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-05-18 12:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 14:17 Andrew Davis
2025-05-18 12:25 ` Krzysztof Kozlowski [this message]
2025-05-19 10:12 ` Mark Brown
2025-05-20 2:28 ` Andrew Davis
2025-05-21 15:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efdfa6fe-2d9f-4c68-93db-08df05af6922@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=afd@ti.com \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®