mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Frans Pop <elendil@planet.nl>,
	linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-arm-kernel@lists.infradead.org,
	Alexey Dobriyan <adobriyan@gmail.com>
Subject: Re: [PATCH] arm: new W macro to WORD_ACCESS
Date: Wed, 16 Sep 2009 21:59:27 +0100	[thread overview]
Message-ID: <1253134767.19743.3.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <20090916175812.GA18993@Chamillionaire.breakpoint.cc>

On Wed, 2009-09-16 at 19:58 +0200, Sebastian Andrzej Siewior wrote:
> As reported by Frans Pop the new global macro W on ARM which is included
> via
> |arch/arm/include/asm/uaccess.h:20
> |include/linux/uaccess.h:5
> |include/linux/crypto.h:26
> |crypto/cast6.c:23
> 
> leads to a build error because the crypto/cast6.c defines a function
> which is named W.

This was already reported by Alexey Dobriyan and I included his patch in
my Thumb-2 branch (and -next for now):

http://linux-arm.org/git?p=linux-2.6.git;a=commitdiff;h=4fb3c2e2ab3549308a1b1663296d165e45d72ba5

Since this macro is only used in ARM assembly code, the patch simply
adds some ifdefs around it.

Russell, if you are OK with Alexey's patch, I'll send you a pull request
(though for only one patch, alternatively just merge it manually).

-- 
Catalin


      parent reply	other threads:[~2009-09-16 21:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 14:01 Build error on arm in crypto/cast6.c Frans Pop
2009-09-16 14:28 ` Frans Pop
2009-09-16 17:58 ` [PATCH] arm: new W macro to WORD_ACCESS Sebastian Andrzej Siewior
2009-09-16 18:38   ` Russell King - ARM Linux
2009-09-16 20:59   ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253134767.19743.3.camel@pc1117.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=adobriyan@gmail.com \
    --cc=elendil@planet.nl \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sebastian@breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®