From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sebastian Andrzej Siewior <sebastian@breakpoint.cc>
Cc: Frans Pop <elendil@planet.nl>,
Herbert Xu <herbert@gondor.apana.org.au>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH] arm: new W macro to WORD_ACCESS
Date: Wed, 16 Sep 2009 19:38:47 +0100 [thread overview]
Message-ID: <20090916183847.GA16457@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20090916175812.GA18993@Chamillionaire.breakpoint.cc>
On Wed, Sep 16, 2009 at 07:58:12PM +0200, Sebastian Andrzej Siewior wrote:
> leads to a build error because the crypto/cast6.c defines a function
> which is named W.
W has nothing to do with the access size, so this change makes it _really_
confusing. What it's about is telling the compiler to use the ARM 32-bit
version of the instruction coding when building for Thumb2 (which
can intermix Thumb and ARM instruction sets.)
So the macro needs to be renamed... NAK on this patch as it stands.
next prev parent reply other threads:[~2009-09-16 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-16 14:01 Build error on arm in crypto/cast6.c Frans Pop
2009-09-16 14:28 ` Frans Pop
2009-09-16 17:58 ` [PATCH] arm: new W macro to WORD_ACCESS Sebastian Andrzej Siewior
2009-09-16 18:38 ` Russell King - ARM Linux [this message]
2009-09-16 20:59 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090916183847.GA16457@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=catalin.marinas@arm.com \
--cc=elendil@planet.nl \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sebastian@breakpoint.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®