mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-usb@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Cliff Cai <cliff.cai@analog.com>
Subject: [PATCH 08/11] USB: musb: clear the Blackfin interrupt pending bits early in the ISR
Date: Wed, 16 Sep 2009 19:38:42 -0400	[thread overview]
Message-ID: <1253144325-1203-8-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1253144325-1203-1-git-send-email-vapier@gentoo.org>

From: Cliff Cai <cliff.cai@analog.com>

If we clear the interrupt pending bits at the end, we sometimes return too
fast and have the same interrupt assert itself.  There is no way in a
Blackfin system to force a sync of this state, so the hardware manual
instructs people to clear interrupt flags early in their ISR.

Signed-off-by: Cliff Cai <cliff.cai@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/usb/musb/musbhsdma.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/musb/musbhsdma.c
index 5e83f96..c767387 100644
--- a/drivers/usb/musb/musbhsdma.c
+++ b/drivers/usb/musb/musbhsdma.c
@@ -259,6 +259,11 @@ static irqreturn_t dma_controller_irq(int irq, void *private_data)
 	if (!int_hsdma)
 		goto done;
 
+#ifdef CONFIG_BLACKFIN
+	/* Clear DMA interrupt flags */
+	musb_writeb(mbase, MUSB_HSDMA_INTR, int_hsdma);
+#endif
+
 	for (bchannel = 0; bchannel < MUSB_HSDMA_CHANNELS; bchannel++) {
 		if (int_hsdma & (1 << bchannel)) {
 			musb_channel = (struct musb_dma_channel *)
@@ -324,11 +329,6 @@ static irqreturn_t dma_controller_irq(int irq, void *private_data)
 		}
 	}
 
-#ifdef CONFIG_BLACKFIN
-	/* Clear DMA interrup flags */
-	musb_writeb(mbase, MUSB_HSDMA_INTR, int_hsdma);
-#endif
-
 	retval = IRQ_HANDLED;
 done:
 	spin_unlock_irqrestore(&musb->lock, flags);
-- 
1.6.5.rc1


  parent reply	other threads:[~2009-09-16 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 23:38 [PATCH 01/11] USB: musb: tweak musb_read_fifo() to avoid unused warnings Mike Frysinger
2009-09-16 23:38 ` [PATCH 02/11] USB: musb: kill compile warning for Blackfin systems Mike Frysinger
2009-09-16 23:38 ` [PATCH 03/11] USB: musb: kill some useless comments in Blackfin driver Mike Frysinger
2009-09-16 23:38 ` [PATCH 04/11] USB: musb: update Blackfin processor dependency Mike Frysinger
2009-09-16 23:38 ` [PATCH 05/11] USB: musb: add notes for Blackfin anomalies Mike Frysinger
2009-09-17 12:33   ` Sergei Shtylyov
2009-09-17 16:25     ` [PATCH 05/12 v2] " Mike Frysinger
2009-09-16 23:38 ` [PATCH 06/11] USB: musb: add work around for Blackfin anomaly 05000456 Mike Frysinger
2009-09-16 23:38 ` [PATCH 07/11] USB: musb: fix musb_platform_set_mode() definition Mike Frysinger
2009-09-16 23:38 ` Mike Frysinger [this message]
2009-09-16 23:38 ` [PATCH 09/11] USB: musb: error out when anomaly 05000380 is applicable Mike Frysinger
2009-09-16 23:38 ` [PATCH 10/11] USB: musb: Blackfin code needs NOP_USB_XCEIV too Mike Frysinger
2009-09-16 23:38 ` [PATCH 11/11] USB: musb: fix printf warning in debug code Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253144325-1203-8-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=cliff.cai@analog.com \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®