mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: linux-usb@vger.kernel.org, Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-kernel@vger.kernel.org,
	uclinux-dist-devel@blackfin.uclinux.org,
	Sonic Zhang <sonic.zhang@analog.com>
Subject: [PATCH 09/11] USB: musb: error out when anomaly 05000380 is applicable
Date: Wed, 16 Sep 2009 19:38:43 -0400	[thread overview]
Message-ID: <1253144325-1203-9-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1253144325-1203-1-git-send-email-vapier@gentoo.org>

From: Sonic Zhang <sonic.zhang@analog.com>

Since we can't work around anomaly 05000380, throw a build error up and
instruct the user to use a different mode.

Signed-off-by: Sonic Zhang <sonic.zhang@analog.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 drivers/usb/musb/blackfin.h |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/usb/musb/blackfin.h b/drivers/usb/musb/blackfin.h
index de62962..21b7730 100644
--- a/drivers/usb/musb/blackfin.h
+++ b/drivers/usb/musb/blackfin.h
@@ -43,6 +43,16 @@
  *             anomaly - 05000465.
  */
 
+/* The Mentor USB DMA engine on BF52x (silicon v0.0 and v0.1) seems to be
+ * unstable in host mode.  This may be caused by Anomaly 05000380.  After
+ * digging out the root cause, we will change this number accordingly.
+ * So, need to either use silicon v0.2+ or disable DMA mode in MUSB.
+ */
+#if ANOMALY_05000380 && defined(CONFIG_BF52x) && \
+    defined(CONFIG_USB_MUSB_HDRC) && !defined(CONFIG_MUSB_PIO_ONLY)
+# error "Please use PIO mode in MUSB driver on bf52x chip v0.0 and v0.1"
+#endif
+
 #undef DUMP_FIFO_DATA
 #ifdef DUMP_FIFO_DATA
 static void dump_fifo_data(u8 *buf, u16 len)
-- 
1.6.5.rc1


  parent reply	other threads:[~2009-09-16 23:39 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 23:38 [PATCH 01/11] USB: musb: tweak musb_read_fifo() to avoid unused warnings Mike Frysinger
2009-09-16 23:38 ` [PATCH 02/11] USB: musb: kill compile warning for Blackfin systems Mike Frysinger
2009-09-16 23:38 ` [PATCH 03/11] USB: musb: kill some useless comments in Blackfin driver Mike Frysinger
2009-09-16 23:38 ` [PATCH 04/11] USB: musb: update Blackfin processor dependency Mike Frysinger
2009-09-16 23:38 ` [PATCH 05/11] USB: musb: add notes for Blackfin anomalies Mike Frysinger
2009-09-17 12:33   ` Sergei Shtylyov
2009-09-17 16:25     ` [PATCH 05/12 v2] " Mike Frysinger
2009-09-16 23:38 ` [PATCH 06/11] USB: musb: add work around for Blackfin anomaly 05000456 Mike Frysinger
2009-09-16 23:38 ` [PATCH 07/11] USB: musb: fix musb_platform_set_mode() definition Mike Frysinger
2009-09-16 23:38 ` [PATCH 08/11] USB: musb: clear the Blackfin interrupt pending bits early in the ISR Mike Frysinger
2009-09-16 23:38 ` Mike Frysinger [this message]
2009-09-16 23:38 ` [PATCH 10/11] USB: musb: Blackfin code needs NOP_USB_XCEIV too Mike Frysinger
2009-09-16 23:38 ` [PATCH 11/11] USB: musb: fix printf warning in debug code Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253144325-1203-9-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=felipe.balbi@nokia.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sonic.zhang@analog.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®