mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: gregkh@suse.de
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
	linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] usb console: 2.6.32 regression fixes
Date: Wed, 16 Sep 2009 22:08:04 -0500	[thread overview]
Message-ID: <1253156887-31597-1-git-send-email-jason.wessel@windriver.com> (raw)

There are 3 regressions in the 2.6.32 development stream for the usb
serial console.

1) A hang in the usb serial core due to a unfreed mutex

2) Crash in the usb serial core if you use a serial console
   because there is a double open of the low level device

3) It is not possible to pass the console baud rate on to
   the first tty open for any usb serial driver other
   than the pl2303 (which has device specific baud
   management).

The first open of the usb serial HW has the termios initialized to
9600 baud, and this will override what ever was setup via the original
console initialization.  The solution is to save the console baud rate
and re-use it later on the first open.

This patch series only applies to the end of the Greg KH usb tree.  It
was tested with a pl2303, mct_u232 and ftdi_sio usb serial devices.

Jason.

Jason Wessel (3):
      usb console: fix mutex lock regression
      usb console,usb-serial: fix regression use of serial->console
      usb console,usb-serial: pass initial console baud on to first tty open

 drivers/usb/serial/console.c    |    2 ++
 drivers/usb/serial/usb-serial.c |   32 +++++++++++++++++---------------
 include/linux/usb/serial.h      |    1 +
 3 files changed, 20 insertions(+), 15 deletions(-)

             reply	other threads:[~2009-09-17  3:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17  3:08 Jason Wessel [this message]
2009-09-17  3:08 ` [PATCH 1/3] usb console: fix mutex lock regression Jason Wessel
2009-09-17  3:08   ` [PATCH 2/3] usb console,usb-serial: fix regression use of serial->console Jason Wessel
2009-09-17  3:08     ` [PATCH 3/3] usb console,usb-serial: pass initial console baud on to first tty open Jason Wessel
2009-09-17  3:32       ` Alan Stern
2009-09-17  3:40         ` Jason Wessel
2009-09-17  3:46           ` Alan Stern
2009-09-17  4:17             ` Jason Wessel
2009-09-17  9:14               ` Alan Cox
2009-09-17 12:16                 ` Jason Wessel
2009-09-17 13:08                   ` Alan Cox
2009-09-17 13:19                     ` Alan Cox
2009-09-17 14:17                       ` Jason Wessel
2009-09-17 16:02                         ` Alan Cox
2009-09-22 20:54                           ` Jason Wessel
2009-09-29 17:24                             ` How to handle console devices Alan Stern
2009-09-29 22:47                               ` Alan Cox
2009-09-17  3:30     ` [PATCH 2/3] usb console,usb-serial: fix regression use of serial->console Alan Stern
2009-09-17  3:32       ` Jason Wessel
2009-09-17  3:25   ` [PATCH 1/3] usb console: fix mutex lock regression Alan Stern
2009-09-17  3:32     ` Jason Wessel
2009-09-18 17:16     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253156887-31597-1-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®