mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.
@ 2009-09-20 14:22 Krzysztof Halasa
  2009-09-20 16:35 ` Daniel Walker
  2009-09-20 16:51 ` Jiri Kosina
  0 siblings, 2 replies; 4+ messages in thread
From: Krzysztof Halasa @ 2009-09-20 14:22 UTC (permalink / raw)
  To: linux-kernel; +Cc: trivial

A comment fix in drivers/ata/pata_hpt37x.c.

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
index 122c786..d0a7df2 100644
--- a/drivers/ata/pata_hpt37x.c
+++ b/drivers/ata/pata_hpt37x.c
@@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
 };
 
 /**
- *	htp37x_clock_slot	-	Turn timing to PC clock entry
+ *	hpt37x_clock_slot	-	Turn timing to PC clock entry
  *	@freq: Reported frequency timing
  *	@base: Base timing
  *

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.
  2009-09-20 14:22 [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c Krzysztof Halasa
@ 2009-09-20 16:35 ` Daniel Walker
  2009-09-20 17:03   ` Krzysztof Halasa
  2009-09-20 16:51 ` Jiri Kosina
  1 sibling, 1 reply; 4+ messages in thread
From: Daniel Walker @ 2009-09-20 16:35 UTC (permalink / raw)
  To: Krzysztof Halasa; +Cc: linux-kernel, trivial

On Sun, 2009-09-20 at 16:22 +0200, Krzysztof Halasa wrote:
> A comment fix in drivers/ata/pata_hpt37x.c.
> 
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
> 

checkpatch has some trouble with your name ..

ERROR: Invalid UTF-8, patch and commit message should be encoded in UTF-8
#42: 
Signed-off-by: Krzysztof Haasa <khc@pm.waw.pl>
                           ^

I've seen this warning a few times, and I wasn't sure to exactly what to
do with it.. However, it does seem like a lot of people have trouble
with the encodings ..

I did a little research and I think I was able to produce your name in
utf8 (checkpatch doesn't error any longer..)

Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>

Are you aware that your name isn't in utf8? Does the above name look
right to you? To me my version looks identical to your version ..

Daniel


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.
  2009-09-20 14:22 [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c Krzysztof Halasa
  2009-09-20 16:35 ` Daniel Walker
@ 2009-09-20 16:51 ` Jiri Kosina
  1 sibling, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2009-09-20 16:51 UTC (permalink / raw)
  To: Krzysztof Halasa; +Cc: linux-kernel

[-- Attachment #1: Type: TEXT/PLAIN, Size: 680 bytes --]

On Sun, 20 Sep 2009, Krzysztof Halasa wrote:

> A comment fix in drivers/ata/pata_hpt37x.c.
> 
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
> 
> diff --git a/drivers/ata/pata_hpt37x.c b/drivers/ata/pata_hpt37x.c
> index 122c786..d0a7df2 100644
> --- a/drivers/ata/pata_hpt37x.c
> +++ b/drivers/ata/pata_hpt37x.c
> @@ -624,7 +624,7 @@ static struct ata_port_operations hpt374_fn1_port_ops = {
>  };
>  
>  /**
> - *	htp37x_clock_slot	-	Turn timing to PC clock entry
> + *	hpt37x_clock_slot	-	Turn timing to PC clock entry
>   *	@freq: Reported frequency timing
>   *	@base: Base timing
>   *

Applied to trivial queue, thanks Krzysztof.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c.
  2009-09-20 16:35 ` Daniel Walker
@ 2009-09-20 17:03   ` Krzysztof Halasa
  0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Halasa @ 2009-09-20 17:03 UTC (permalink / raw)
  To: Daniel Walker; +Cc: linux-kernel, trivial

Daniel Walker <dwalker@fifo99.com> writes:

> I did a little research and I think I was able to produce your name in
> utf8 (checkpatch doesn't error any longer..)
>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> Are you aware that your name isn't in utf8? Does the above name look
> right to you? To me my version looks identical to your version ..

Well, it looks like at some point I instructed my Gnus to send in ISO
8859-* encoding if possible. Probably you used the raw "mail spool"
file, instead of converting to UTF-8. Not much surprise, though. There
is no reason for me to use 8859 encodings anymore, I've just switched
that to UTF-8.

Thanks for noticing.
-- 
Krzysztof Hałasa

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2009-09-20 17:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-09-20 14:22 [PATCH][TRIVIAL] Fix comment in drivers/ata/pata_hpt37x.c Krzysztof Halasa
2009-09-20 16:35 ` Daniel Walker
2009-09-20 17:03   ` Krzysztof Halasa
2009-09-20 16:51 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®