mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tim Abbott <tabbott@ksplice.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Sam Ravnborg <sam@ravnborg.org>, Tim Abbott <tabbott@ksplice.com>
Subject: [PATCH v2 01/11] Optimize the ordering of sections in RW_DATA_SECTION.
Date: Thu, 24 Sep 2009 10:36:16 -0400	[thread overview]
Message-ID: <1253802986-8132-2-git-send-email-tabbott@ksplice.com> (raw)
In-Reply-To: <1253802986-8132-1-git-send-email-tabbott@ksplice.com>

The old RW_DATA_SECTION had INIT_TASK_DATA (which was
more-than-PAGE_SIZE-aligned), followed by a bunch of small alignment
stuff, followed by more PAGE_SIZE-aligned stuff, so you wasted memory
in the middle of .data re-aligning back up to PAGE_SIZE.

This patch sorts the sections by alignment requirements, which should
pack them essentially optimally.

Signed-off-by: Tim Abbott <tabbott@ksplice.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
---
 include/asm-generic/vmlinux.lds.h |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 29ca8f5..b6e818f 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -721,12 +721,12 @@
 	. = ALIGN(PAGE_SIZE);						\
 	.data : AT(ADDR(.data) - LOAD_OFFSET) {				\
 		INIT_TASK_DATA(inittask)				\
+		NOSAVE_DATA						\
+		PAGE_ALIGNED_DATA(pagealigned)				\
 		CACHELINE_ALIGNED_DATA(cacheline)			\
 		READ_MOSTLY_DATA(cacheline)				\
 		DATA_DATA						\
 		CONSTRUCTORS						\
-		NOSAVE_DATA						\
-		PAGE_ALIGNED_DATA(pagealigned)				\
 	}
 
 #define INIT_TEXT_SECTION(inittext_align)				\
-- 
1.6.3.3


  reply	other threads:[~2009-09-24 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 14:36 [PATCH v2 00/11] Linker script cleanups for various architectures Tim Abbott
2009-09-24 14:36 ` Tim Abbott [this message]
2009-09-24 14:36 ` [PATCH v2 02/11] parisc: Clean up linker script using new linker script macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 03/11] parisc: Remove useless altinstructions code copied from x86 Tim Abbott
2009-09-24 14:36 ` [PATCH v2 04/11] xtensa: Cleanup linker script using new linker script macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 05/11] um: Clean up linker script using standard macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 06/11] h8300: Cleanup linker script using new linker script macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 07/11] mn10300: Clean up linker script using higher-level macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 08/11] blackfin: Cleanup linker script using new linker script macros Tim Abbott
2009-09-24 14:36 ` [PATCH v2 09/11] powerpc: " Tim Abbott
2009-09-24 14:36 ` [PATCH v2 10/11] alpha: use .data.init_task instead of .data.init_thread Tim Abbott
2009-09-24 14:36 ` [PATCH v2 11/11] alpha: Clean up linker script using new linker script macros Tim Abbott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253802986-8132-2-git-send-email-tabbott@ksplice.com \
    --to=tabbott@ksplice.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®