mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bernhard Walle <bernhard@bwalle.de>
To: akpm@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, Bernhard Walle <bernhard@bwalle.de>
Subject: [PATCH 1/5] Only define/declare kmsg_redirect when CONFIG_VT_CONSOLE is set
Date: Sat, 10 Oct 2009 22:51:06 +0200	[thread overview]
Message-ID: <1255207870-24496-2-git-send-email-bernhard@bwalle.de> (raw)
In-Reply-To: <1255207870-24496-1-git-send-email-bernhard@bwalle.de>

Since the variable is only used when CONFIG_VT_CONSOLE is set, we can save some
bytes of memory when CONFIG_VT_CONSOLE is not set.


Signed-off-by: Bernhard Walle <bernhard@bwalle.de>
---
 drivers/char/vt.c   |    2 ++
 include/linux/tty.h |    2 ++
 2 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 0c80c68..c3b1a86 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -187,7 +187,9 @@ static DECLARE_WORK(console_work, console_callback);
 int fg_console;
 int last_console;
 int want_console = -1;
+#ifdef CONFIG_VT_CONSOLE
 int kmsg_redirect;
+#endif
 
 /*
  * For each existing display, we have a pointer to console currently visible
diff --git a/include/linux/tty.h b/include/linux/tty.h
index f0f43d0..91bb1df 100644
--- a/include/linux/tty.h
+++ b/include/linux/tty.h
@@ -340,7 +340,9 @@ extern void tty_write_flush(struct tty_struct *);
 
 extern struct ktermios tty_std_termios;
 
+#ifdef CONFIG_VT_CONSOLE
 extern int kmsg_redirect;
+#endif
 
 extern void console_init(void);
 extern int vcs_init(void);
-- 
1.6.3.3


  reply	other threads:[~2009-10-10 20:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-10 20:51 Always print panic message on current console Bernhard Walle
2009-10-10 20:51 ` Bernhard Walle [this message]
2009-10-10 22:56   ` [PATCH 1/5] Only define/declare kmsg_redirect when CONFIG_VT_CONSOLE is set Alan Cox
2009-10-10 20:51 ` [PATCH 2/5] Add setter/getter interface for kmsg_redirect Bernhard Walle
2009-10-10 22:58   ` Alan Cox
2009-10-10 20:51 ` [PATCH 3/5] Use vt_get_kmsg_redirect() and vt_set_kmsg_redirect() Bernhard Walle
2009-10-10 23:06   ` Alan Cox
2009-10-10 23:25     ` Alan Cox
2009-10-10 20:51 ` [PATCH 4/5] Make kmsg_redirect static Bernhard Walle
2009-10-10 20:51 ` [PATCH 5/5] Always print panic message on current console Bernhard Walle
2009-10-12 17:36   ` Andi Kleen
2009-10-12 18:24     ` Bernhard Walle
2009-10-12 18:30       ` Jesse Barnes
2009-10-12 18:34         ` Bernhard Walle
2009-10-14  0:02           ` Jason Wessel
2009-10-12 18:42         ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255207870-24496-2-git-send-email-bernhard@bwalle.de \
    --to=bernhard@bwalle.de \
    --cc=akpm@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®