From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Bernhard Walle <bernhard@bwalle.de>
Cc: akpm@linuxfoundation.org, linux-kernel@vger.kernel.org,
Bernhard Walle <bernhard@bwalle.de>
Subject: Re: [PATCH 2/5] Add setter/getter interface for kmsg_redirect
Date: Sat, 10 Oct 2009 23:58:22 +0100 [thread overview]
Message-ID: <20091010235822.3a7992dd@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1255207870-24496-3-git-send-email-bernhard@bwalle.de>
> +int vt_get_kmsg_redirect(void)
> +{
> + return kmsg_redirect;
> +}
Explain the locking rules
> +#ifdef CONFIG_VT_CONSOLE
> +
> +extern void vt_set_kmsg_redirect(int vt);
> +extern int vt_get_kmsg_redirect(void);
Just make them extern inline, its a one liner.
next prev parent reply other threads:[~2009-10-10 22:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-10 20:51 Always print panic message on current console Bernhard Walle
2009-10-10 20:51 ` [PATCH 1/5] Only define/declare kmsg_redirect when CONFIG_VT_CONSOLE is set Bernhard Walle
2009-10-10 22:56 ` Alan Cox
2009-10-10 20:51 ` [PATCH 2/5] Add setter/getter interface for kmsg_redirect Bernhard Walle
2009-10-10 22:58 ` Alan Cox [this message]
2009-10-10 20:51 ` [PATCH 3/5] Use vt_get_kmsg_redirect() and vt_set_kmsg_redirect() Bernhard Walle
2009-10-10 23:06 ` Alan Cox
2009-10-10 23:25 ` Alan Cox
2009-10-10 20:51 ` [PATCH 4/5] Make kmsg_redirect static Bernhard Walle
2009-10-10 20:51 ` [PATCH 5/5] Always print panic message on current console Bernhard Walle
2009-10-12 17:36 ` Andi Kleen
2009-10-12 18:24 ` Bernhard Walle
2009-10-12 18:30 ` Jesse Barnes
2009-10-12 18:34 ` Bernhard Walle
2009-10-14 0:02 ` Jason Wessel
2009-10-12 18:42 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091010235822.3a7992dd@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linuxfoundation.org \
--cc=bernhard@bwalle.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®