mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Fertser <fercerpav@gmail.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Nelson Castillo <arhuaco@freaks-unidos.net>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Paul Fertser <fercerpav@gmail.com>
Subject: [PATCH 2/7] mfd: pcf50633: make suspend/resume belong to i2c_driver
Date: Wed, 14 Oct 2009 02:12:31 +0400	[thread overview]
Message-ID: <1255471956-29201-2-git-send-email-fercerpav@gmail.com> (raw)
In-Reply-To: <1255471956-29201-1-git-send-email-fercerpav@gmail.com>

From: Lars-Peter Clausen <lars@metafoo.de>

When not using the i2c suspend/resume callbacks the i2c client resumed
before the i2c master.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
---
 drivers/mfd/pcf50633-core.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 6efe5c3..a844445 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -485,13 +485,13 @@ pcf50633_client_dev_register(struct pcf50633 *pcf, const char *name,
 }
 
 #ifdef CONFIG_PM
-static int pcf50633_suspend(struct device *dev, pm_message_t state)
+static int pcf50633_suspend(struct i2c_client *client, pm_message_t state)
 {
 	struct pcf50633 *pcf;
 	int ret = 0, i;
 	u8 res[5];
 
-	pcf = dev_get_drvdata(dev);
+	pcf = i2c_get_clientdata(client);
 
 	/* Make sure our interrupt handlers are not called
 	 * henceforth */
@@ -526,12 +526,12 @@ out:
 	return ret;
 }
 
-static int pcf50633_resume(struct device *dev)
+static int pcf50633_resume(struct i2c_client *client)
 {
 	struct pcf50633 *pcf;
 	int ret;
 
-	pcf = dev_get_drvdata(dev);
+	pcf = i2c_get_clientdata(client);
 
 	/* Write the saved mask registers */
 	ret = pcf50633_write_block(pcf, PCF50633_REG_INT1M,
@@ -689,12 +689,12 @@ static struct i2c_device_id pcf50633_id_table[] = {
 static struct i2c_driver pcf50633_driver = {
 	.driver = {
 		.name	= "pcf50633",
-		.suspend = pcf50633_suspend,
-		.resume	= pcf50633_resume,
 	},
 	.id_table = pcf50633_id_table,
 	.probe = pcf50633_probe,
 	.remove = __devexit_p(pcf50633_remove),
+	.suspend = pcf50633_suspend,
+	.resume	= pcf50633_resume,
 };
 
 static int __init pcf50633_init(void)
-- 
1.6.0.6


  reply	other threads:[~2009-10-13 22:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 22:12 [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys Paul Fertser
2009-10-13 22:12 ` Paul Fertser [this message]
2009-10-13 22:12   ` [PATCH 3/7] mfd: pcf50633: move messages to appropriate log levels Paul Fertser
2009-10-13 22:12     ` [PATCH 4/7] mfd: pcf50633: Fix memleak in pcf50633_client_dev_register Paul Fertser
2009-10-13 22:12       ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Paul Fertser
2009-10-13 22:12         ` [PATCH 6/7] mfd: pcf50633: Use platform_device_add_data to set regulator platform data Paul Fertser
2009-10-13 22:12           ` [PATCH 7/7] mfd: pcf50633: Fix pcf50633-regulator drvdata usage Paul Fertser
2009-10-19 15:08         ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Samuel Ortiz
2009-10-19 23:09           ` Paul Fertser
2009-10-20  9:23             ` Samuel Ortiz
2009-10-19 15:38 ` [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255471956-29201-2-git-send-email-fercerpav@gmail.com \
    --to=fercerpav@gmail.com \
    --cc=arhuaco@freaks-unidos.net \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®