mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Fertser <fercerpav@gmail.com>
To: Samuel Ortiz <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org,
	Nelson Castillo <arhuaco@freaks-unidos.net>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Paul Fertser <fercerpav@gmail.com>
Subject: [PATCH 6/7] mfd: pcf50633: Use platform_device_add_data to set regulator platform data
Date: Wed, 14 Oct 2009 02:12:35 +0400	[thread overview]
Message-ID: <1255471956-29201-6-git-send-email-fercerpav@gmail.com> (raw)
In-Reply-To: <1255471956-29201-5-git-send-email-fercerpav@gmail.com>

From: Lars-Peter Clausen <lars@metafoo.de>

Platform devices allocated with platform_device_alloc should use
platform_device_add_data to set the platform data, because kfree will be called
on the platform_data when the device is released.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
---
 drivers/mfd/pcf50633-core.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/mfd/pcf50633-core.c b/drivers/mfd/pcf50633-core.c
index 2e7f903..4604ba5 100644
--- a/drivers/mfd/pcf50633-core.c
+++ b/drivers/mfd/pcf50633-core.c
@@ -630,7 +630,8 @@ static int __devinit pcf50633_probe(struct i2c_client *client,
 		}
 
 		pdev->dev.parent = pcf->dev;
-		pdev->dev.platform_data = &pdata->reg_init_data[i];
+		platform_device_add_data(pdev, &pdata->reg_init_data[i],
+					sizeof(pdata->reg_init_data[i]));
 		dev_set_drvdata(&pdev->dev, pcf);
 		pcf->regulator_pdev[i] = pdev;
 
-- 
1.6.0.6


  reply	other threads:[~2009-10-13 22:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 22:12 [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys Paul Fertser
2009-10-13 22:12 ` [PATCH 2/7] mfd: pcf50633: make suspend/resume belong to i2c_driver Paul Fertser
2009-10-13 22:12   ` [PATCH 3/7] mfd: pcf50633: move messages to appropriate log levels Paul Fertser
2009-10-13 22:12     ` [PATCH 4/7] mfd: pcf50633: Fix memleak in pcf50633_client_dev_register Paul Fertser
2009-10-13 22:12       ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Paul Fertser
2009-10-13 22:12         ` Paul Fertser [this message]
2009-10-13 22:12           ` [PATCH 7/7] mfd: pcf50633: Fix pcf50633-regulator drvdata usage Paul Fertser
2009-10-19 15:08         ` [PATCH 5/7] mfd: pcf50633: Cleanup pcf50633_probe error handling Samuel Ortiz
2009-10-19 23:09           ` Paul Fertser
2009-10-20  9:23             ` Samuel Ortiz
2009-10-19 15:38 ` [PATCH 1/7] mfd: pcf50633 disable unnecessary shutdown on lowsys Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255471956-29201-6-git-send-email-fercerpav@gmail.com \
    --to=fercerpav@gmail.com \
    --cc=arhuaco@freaks-unidos.net \
    --cc=lars@metafoo.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®