mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "hpa@zytor.com" <hpa@zytor.com>, "mingo@elte.hu" <mingo@elte.hu>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"arjan@linux.jf.intel.com" <arjan@linux.jf.intel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Ma, Chinang" <chinang.ma@intel.com>
Subject: Re: [patch 2/2] x86_64: align RODATA kernel section to 2MB with CONFIG_DEBUG_RODATA
Date: Thu, 15 Oct 2009 13:23:48 -0700	[thread overview]
Message-ID: <1255638228.2532.4.camel@sbs-t61> (raw)
In-Reply-To: <20091015032429.GA10068@merkur.ravnborg.org>

On Wed, 2009-10-14 at 20:24 -0700, Sam Ravnborg wrote:
> > +#else
> > +
> > +#define X64_ALIGN_DEBUG_RODATA_BEGIN
> > +#define X64_ALIGN_DEBUG_RODATA_END
> > +
> > +#endif
> 
> A coment describing the purpose of
> this would be nice.

I will update this in the next version of the patch.

> > @@ -726,9 +726,13 @@ void set_kernel_text_ro(void)
> >  
> >  void mark_rodata_ro(void)
> >  {
> > -	unsigned long start = PFN_ALIGN(_text), end = PFN_ALIGN(__end_rodata);
> > +	unsigned long start = PFN_ALIGN(_text);
> >  	unsigned long rodata_start =
> >  		((unsigned long)__start_rodata + PAGE_SIZE - 1) & PAGE_MASK;
> > +	unsigned long end = (unsigned long) &__end_rodata_hpage_align;
> Here the symbol seems to be referenced unconditionally.

This function is defined only for CONFIG_DEBUG_RODATA.

thanks,
suresh


  reply	other threads:[~2009-10-15 20:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-14 21:46 [patch 0/2] x86_64: preserve large page text mappings " Suresh Siddha
2009-10-14 21:46 ` [patch 1/2] x86_64: preserve large page mapping for 1st 2MB kernel txt " Suresh Siddha
2009-10-24  1:03   ` [tip:branch?] x86-64: " tip-bot for Suresh Siddha
2009-10-14 21:46 ` [patch 2/2] x86_64: align RODATA kernel section to 2MB " Suresh Siddha
2009-10-15  3:24   ` Sam Ravnborg
2009-10-15 20:23     ` Suresh Siddha [this message]
2009-10-24  1:03   ` [tip:branch?] x86-64: " tip-bot for Suresh Siddha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255638228.2532.4.camel@sbs-t61 \
    --to=suresh.b.siddha@intel.com \
    --cc=arjan@linux.jf.intel.com \
    --cc=chinang.ma@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sam@ravnborg.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®