From: Suresh Siddha <suresh.b.siddha@intel.com>
To: hpa@zytor.com, mingo@elte.hu, tglx@linutronix.de,
arjan@linux.jf.intel.com
Cc: linux-kernel@vger.kernel.org, chinang.ma@intel.com,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: [patch 1/2] x86_64: preserve large page mapping for 1st 2MB kernel txt with CONFIG_DEBUG_RODATA
Date: Wed, 14 Oct 2009 14:46:55 -0700 [thread overview]
Message-ID: <20091014220254.063193621@sbs-t61.sc.intel.com> (raw)
In-Reply-To: <20091014214654.423040927@sbs-t61.sc.intel.com>
[-- Attachment #1: prevent_kernel_text_lp.patch --]
[-- Type: text/plain, Size: 2438 bytes --]
In the first 2MB, kernel text is co-located with kernel static
page tables setup by head_64.S. CONFIG_DEBUG_RODATA chops this
2MB large page mapping to small 4KB pages as we mark the kernel text as RO,
leaving the static page tables as RW.
With CONFIG_DEBUG_RODATA disabled, OLTP run on NHM-EP shows 1% improvement
with 2% reduction in system time and 1% improvement in iowait idle time.
To recover this, move the kernel static page tables to .data section, so that
we don't have to break the first 2MB of kernel text to small pages with
CONFIG_DEBUG_RODATA.
Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---
arch/x86/kernel/head_64.S | 3 ++-
arch/x86/mm/init_64.c | 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
Index: tree/arch/x86/kernel/head_64.S
===================================================================
--- tree.orig/arch/x86/kernel/head_64.S
+++ tree/arch/x86/kernel/head_64.S
@@ -262,11 +262,11 @@ ENTRY(secondary_startup_64)
.quad x86_64_start_kernel
ENTRY(initial_gs)
.quad INIT_PER_CPU_VAR(irq_stack_union)
- __FINITDATA
ENTRY(stack_start)
.quad init_thread_union+THREAD_SIZE-8
.word 0
+ __FINITDATA
bad_address:
jmp bad_address
@@ -340,6 +340,7 @@ ENTRY(name)
i = i + 1 ; \
.endr
+ .data
/*
* This default setting generates an ident mapping at address 0x100000
* and a mapping for the kernel that precisely maps virtual address
Index: tree/arch/x86/mm/init_64.c
===================================================================
--- tree.orig/arch/x86/mm/init_64.c
+++ tree/arch/x86/mm/init_64.c
@@ -698,7 +698,7 @@ static int kernel_set_to_readonly;
void set_kernel_text_rw(void)
{
- unsigned long start = PFN_ALIGN(_stext);
+ unsigned long start = PFN_ALIGN(_text);
unsigned long end = PFN_ALIGN(__start_rodata);
if (!kernel_set_to_readonly)
@@ -712,7 +712,7 @@ void set_kernel_text_rw(void)
void set_kernel_text_ro(void)
{
- unsigned long start = PFN_ALIGN(_stext);
+ unsigned long start = PFN_ALIGN(_text);
unsigned long end = PFN_ALIGN(__start_rodata);
if (!kernel_set_to_readonly)
@@ -726,7 +726,7 @@ void set_kernel_text_ro(void)
void mark_rodata_ro(void)
{
- unsigned long start = PFN_ALIGN(_stext), end = PFN_ALIGN(__end_rodata);
+ unsigned long start = PFN_ALIGN(_text), end = PFN_ALIGN(__end_rodata);
unsigned long rodata_start =
((unsigned long)__start_rodata + PAGE_SIZE - 1) & PAGE_MASK;
next prev parent reply other threads:[~2009-10-14 22:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 21:46 [patch 0/2] x86_64: preserve large page text mappings " Suresh Siddha
2009-10-14 21:46 ` Suresh Siddha [this message]
2009-10-24 1:03 ` [tip:branch?] x86-64: preserve large page mapping for 1st 2MB kernel txt " tip-bot for Suresh Siddha
2009-10-14 21:46 ` [patch 2/2] x86_64: align RODATA kernel section to 2MB " Suresh Siddha
2009-10-15 3:24 ` Sam Ravnborg
2009-10-15 20:23 ` Suresh Siddha
2009-10-24 1:03 ` [tip:branch?] x86-64: " tip-bot for Suresh Siddha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014220254.063193621@sbs-t61.sc.intel.com \
--to=suresh.b.siddha@intel.com \
--cc=arjan@linux.jf.intel.com \
--cc=chinang.ma@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®