From: Johannes Berg <johannes@sipsolutions.net>
To: Tilman Schmidt <tilman@imap.cc>
Cc: Jarek Poplawski <jarkao2@gmail.com>,
David Miller <davem@davemloft.net>,
hidave.darkstar@gmail.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-wireless@vger.kernel.org,
linux-ppp@vger.kernel.org, netdev@vger.kernel.org,
paulus@samba.org, isdn4linux <isdn4linux@listserv.isdn4linux.de>,
i4ldeveloper <i4ldeveloper@listserv.isdn4linux.de>,
Karsten Keil <isdn@linux-pingi.de>
Subject: Re: NOHZ: local_softirq_pending 08
Date: Fri, 23 Oct 2009 15:34:29 +0200 [thread overview]
Message-ID: <1256304869.12174.20.camel@johannes.local> (raw)
In-Reply-To: <4AE0ECCE.2020407@imap.cc>
[-- Attachment #1: Type: text/plain, Size: 566 bytes --]
On Fri, 2009-10-23 at 01:37 +0200, Tilman Schmidt wrote:
> --- a/drivers/isdn/i4l/isdn_ppp.c
> +++ b/drivers/isdn/i4l/isdn_ppp.c
> @@ -1174,7 +1174,10 @@ isdn_ppp_push_higher(isdn_net_dev * net_dev, isdn_net_local * lp, struct sk_buff
> #endif /* CONFIG_IPPP_FILTER */
> skb->dev = dev;
> skb_reset_mac_header(skb);
> - netif_rx(skb);
> + if (in_interrupt())
> + netif_rx(skb);
> + else
> + netif_rx_ni(skb);
So you've verified that the entire i4l stack can cope with being called
twice on the same CPU, from different contexts?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2009-10-23 13:35 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-11 9:52 Dave Young
2009-10-11 10:08 ` Johannes Berg
2009-10-11 10:17 ` Michael Buesch
2009-10-11 10:37 ` Johannes Berg
2009-10-11 10:38 ` David Miller
2009-10-11 10:55 ` Dave Young
2009-10-11 11:18 ` Tilman Schmidt
2009-10-11 11:40 ` Johannes Berg
2009-10-12 8:28 ` Tilman Schmidt
2009-10-12 10:32 ` David Miller
2009-10-12 11:25 ` Tilman Schmidt
2009-10-15 11:40 ` Jarek Poplawski
2009-10-15 17:53 ` Jarek Poplawski
2009-10-21 18:46 ` Tilman Schmidt
2009-10-21 21:19 ` [PATCH] net: Adjust softirq raising in __napi_schedule Jarek Poplawski
2009-10-21 21:25 ` Johannes Berg
2009-10-21 21:37 ` Tilman Schmidt
2009-10-21 21:39 ` Jarek Poplawski
2009-10-22 8:27 ` Johannes Berg
2009-10-23 14:39 ` Tilman Schmidt
2009-10-23 14:46 ` Johannes Berg
2009-10-26 7:41 ` Jarek Poplawski
2009-10-26 7:44 ` Johannes Berg
2009-10-26 7:54 ` Jarek Poplawski
2009-10-26 7:58 ` Johannes Berg
2009-10-26 8:47 ` Tilman Schmidt
2009-10-26 8:56 ` Johannes Berg
2009-10-27 0:52 ` Tilman Schmidt
2009-10-27 7:01 ` Johannes Berg
2009-10-22 11:29 ` David Miller
2009-10-22 12:54 ` Jarek Poplawski
2009-10-22 23:37 ` NOHZ: local_softirq_pending 08 Tilman Schmidt
2009-10-23 13:34 ` Johannes Berg [this message]
2009-10-23 14:27 ` Tilman Schmidt
2009-10-23 14:31 ` Johannes Berg
2009-10-23 16:33 ` Tilman Schmidt
2009-10-11 16:39 ` Joe Korty
-- strict thread matches above, loose matches on Subject: below --
2012-05-30 21:48 Dave Jones
2012-05-31 7:52 ` Thomas Gleixner
2012-05-31 7:56 ` Eric Dumazet
2012-05-31 14:04 ` Dave Jones
2012-06-08 16:46 ` Nikos Chantziaras
2012-06-01 22:57 ` Francois Romieu
2012-06-02 20:58 ` Marc Dionne
2012-06-05 23:15 ` Francois Romieu
2012-06-06 1:46 ` Dave Jones
2012-06-06 5:42 ` Francois Romieu
2012-06-08 2:34 ` Dave Jones
2012-06-08 7:57 ` Thomas Gleixner
2012-06-08 14:23 ` Dave Jones
2012-06-08 14:51 ` Thomas Gleixner
2012-06-08 20:27 ` Francois Romieu
2012-06-08 20:41 ` Thomas Gleixner
2012-06-08 21:53 ` Francois Romieu
2012-06-08 22:33 ` Marc Dionne
2012-06-10 20:40 ` Dave Jones
2012-06-25 12:38 ` Johannes Stezenbach
2012-06-25 19:28 ` Francois Romieu
2012-06-25 19:52 ` Dave Jones
2012-06-08 8:32 ` Johannes Stezenbach
2007-05-29 6:01 Rafał Bilski
2007-05-28 21:04 Rafał Bilski
2007-05-28 22:12 ` Anant Nitya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256304869.12174.20.camel@johannes.local \
--to=johannes@sipsolutions.net \
--cc=davem@davemloft.net \
--cc=hidave.darkstar@gmail.com \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=jarkao2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ppp@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®