From: Catalin Marinas <catalin.marinas@arm.com>
To: Claudio Scordino <claudio@evidence.eu.com>
Cc: linux-kernel@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
linux-arm-kernel@lists.arm.linux.org.uk,
akpm@linux-foundation.org
Subject: Re: [PATCH][RE-SUBMIT] Default setting of the ARM_UNWIND option
Date: Mon, 26 Oct 2009 11:10:52 +0000 [thread overview]
Message-ID: <1256555452.5282.21.camel@pc1117.cambridge.arm.com> (raw)
In-Reply-To: <4AE55D83.7080608@evidence.eu.com>
On Mon, 2009-10-26 at 09:27 +0100, Claudio Scordino wrote:
> My ARM board hanged at the initial "Calibrating delay loop" message.
>
> After some inspection, I found out the problem to be with commit
> adf8b37bafc1495393201a2ae4235846371870d0. This commit introduces stack
> unwinding for ARM, and set it enabled by default. However, it seems to
> not work with buggy or not-EABI compilers.
>
> My suggestion is to keep the feature (which is fine) but change the
> default setting of the option (see the attached patch).
The option still depends on EXPERIMENTAL, so you get ARM_UNWIND on when
enabling that.
I'm more in favour of a #warning on #error in the unwind.c file based on
the compiler version rather than not having it on by default. The reason
is that people reported performance improvements when compiling the
kernel without frame pointers.
--
Catalin
next prev parent reply other threads:[~2009-10-26 11:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AD73DA4.4050006@evidence.eu.com>
[not found] ` <1255620333.10164.77.camel@pc1117.cambridge.arm.com>
2009-10-19 10:15 ` [PATCH] " Claudio Scordino
2009-10-19 10:16 ` Claudio Scordino
2009-10-26 8:27 ` [PATCH][RE-SUBMIT] " Claudio Scordino
2009-10-26 11:10 ` Catalin Marinas [this message]
2009-10-28 11:37 ` Claudio Scordino
2009-10-28 11:37 ` Claudio Scordino
2009-10-28 14:58 ` Catalin Marinas
2009-10-30 11:11 ` Claudio Scordino
2009-10-30 12:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256555452.5282.21.camel@pc1117.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=akpm@linux-foundation.org \
--cc=claudio@evidence.eu.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®