From: Claudio Scordino <claudio@evidence.eu.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, rmk+kernel@arm.linux.org.uk,
akpm@linux-foundation.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH][RE-SUBMIT] Default setting of the ARM_UNWIND option
Date: Fri, 30 Oct 2009 12:11:20 +0100 [thread overview]
Message-ID: <4AEAC9D8.9000304@evidence.eu.com> (raw)
In-Reply-To: <1256741902.27121.29.camel@pc1117.cambridge.arm.com>
[-- Attachment #1: Type: text/plain, Size: 240 bytes --]
Hi,
I modified the patch according to your suggestions.
>
> You can just send it to Russell's patch system once there are no more
> comments on it.
Done. I'm attaching the latest version here too.
Many thanks,
Claudio
[-- Attachment #2: 0001-ARM-unwind-is-known-to-compile-only-with-EABI-and-no.patch --]
[-- Type: text/x-patch, Size: 1372 bytes --]
From: Claudio Scordino <claudio@evidence.eu.com>
Date: Fri, 30 Oct 2009 11:46:00 +0100
Subject: [PATCH 1/1] ARM unwind is known to compile only with EABI and not-buggy compilers.
ARM unwind is known to compile only with EABI and not-buggy compilers.
The problem is not the unwinding information but the -fno-frame-pointer option added as a result of !CONFIG_FRAME_POINTER.
Now we check the compiler and raise a #warning in case of wrong compiler.
Signed-off-by: Claudio Scordino <claudio@evidence.eu.com>
---
arch/arm/kernel/unwind.c | 9 +++++++++
1 files changed, 9 insertions(+), 0 deletions(-)
diff --git a/arch/arm/kernel/unwind.c b/arch/arm/kernel/unwind.c
index 39baf11..786ac2b 100644
--- a/arch/arm/kernel/unwind.c
+++ b/arch/arm/kernel/unwind.c
@@ -26,6 +26,15 @@
* http://infocenter.arm.com/help/topic/com.arm.doc.subset.swdev.abi/index.html
*/
+#if !defined (__ARM_EABI__)
+#warning Your compiler does not have EABI support.
+#warning ARM unwind is known to compile only with EABI compilers.
+#warning Change compiler or disable ARM_UNWIND option.
+#elif (__GNUC__ == 4 && __GNUC_MINOR__ <= 2)
+#warning Your compiler is too buggy; it is known to not compile ARM unwind support.
+#warning Change compiler or disable ARM_UNWIND option.
+#endif
+
#include <linux/kernel.h>
#include <linux/init.h>
#include <linux/module.h>
--
1.6.0.4
next prev parent reply other threads:[~2009-10-30 11:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4AD73DA4.4050006@evidence.eu.com>
[not found] ` <1255620333.10164.77.camel@pc1117.cambridge.arm.com>
2009-10-19 10:15 ` [PATCH] " Claudio Scordino
2009-10-19 10:16 ` Claudio Scordino
2009-10-26 8:27 ` [PATCH][RE-SUBMIT] " Claudio Scordino
2009-10-26 11:10 ` Catalin Marinas
2009-10-28 11:37 ` Claudio Scordino
2009-10-28 11:37 ` Claudio Scordino
2009-10-28 14:58 ` Catalin Marinas
2009-10-30 11:11 ` Claudio Scordino [this message]
2009-10-30 12:39 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AEAC9D8.9000304@evidence.eu.com \
--to=claudio@evidence.eu.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome