mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@nokia.com>
To: alsa-devel@alsa-project.org, linux-omap@vger.kernel.org,
	sameo@linux.intel.com
Cc: linux-kernel@vger.kernel.org, tony@atomide.com,
	broonie@opensource.wolfsonmicro.com
Subject: [PATCH 0/5] ASoC/MFD/OMAP: TWL4030: APLL_CTL handling change
Date: Mon,  2 Nov 2009 14:34:50 +0200	[thread overview]
Message-ID: <1257165295-9352-1-git-send-email-peter.ujfalusi@nokia.com> (raw)

Hello,

The following series changes the way how the APLL_CTL register is handled by
the twl4030 codec related drivers.
Moving the configuration of APLL_CTL register from child drivers (specifically
from soc codec driver) to the twl4030-codec MFD driver.
Because the audio_mclk is static, board specific and can not be changed in
runtime, the codec MFD is the right place to configure it early enough, so
child can use the hardware correctly.
Before this patch for example the APLL_INFREQ was configured first, when the
user played or recorded audio via the twl4030.
The digital bypass needs correct APLL_INFREQ to be configured in order to work
properly. If the digital bypass enabled before any audio activity, in some
cases the bypassed audio was not correct.

The series also addresses the issue, that after boot-up, neither of the
loopbacks was working, because the codec was actually off.
Setting the codec->bias_level to _OFF, before setting the codec bias level to
STANDBY fixes this issue.

This series is on top of Takashi's sound-2.6 topic/asoc branch, which has the
twl403-codec MFD and related patches for 2.6.33.

It would be really nice, if this series would make it also to the same branch,
since this fixes some real anomalies brought in by the cleanup of the twl4030
codec related drivers.
These problems were hidden before because of the inconsistent handling of bits
and states in the codec driver in the past.

Thank you,

---
Peter Ujfalusi (5):
  MFD: TWL4030: Add audio_mclk to the codec platform data
  OMAP: Configure audio_mclk for twl4030-codec MFD
  MFD: twl4030-codec: APLL_INFREQ handling in the MFD driver
  ASoC: TWL4030: Make sure, that the codec is powered on startup
  ASoC: TWL4030: Do not modify the APLL_CTL register

 arch/arm/mach-omap2/board-3430sdp.c      |    1 +
 arch/arm/mach-omap2/board-omap3beagle.c  |    1 +
 arch/arm/mach-omap2/board-omap3evm.c     |    1 +
 arch/arm/mach-omap2/board-omap3pandora.c |    1 +
 arch/arm/mach-omap2/board-overo.c        |    1 +
 arch/arm/mach-omap2/board-zoom2.c        |    1 +
 drivers/mfd/twl4030-codec.c              |   40 +++++++++++++++++
 include/linux/i2c/twl4030.h              |    1 +
 include/linux/mfd/twl4030-codec.h        |    1 +
 sound/soc/codecs/twl4030.c               |   70 +++++++++++------------------
 10 files changed, 75 insertions(+), 43 deletions(-)


             reply	other threads:[~2009-11-02 12:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 12:34 Peter Ujfalusi [this message]
2009-11-02 12:34 ` [PATCH 1/5] MFD: TWL4030: Add audio_mclk to the codec platform data Peter Ujfalusi
2009-11-02 12:34   ` [PATCH 2/5] OMAP: Configure audio_mclk for twl4030-codec MFD Peter Ujfalusi
2009-11-02 12:34     ` [PATCH 3/5] MFD: twl4030-codec: APLL_INFREQ handling in the MFD driver Peter Ujfalusi
2009-11-02 12:34       ` [PATCH 4/5] ASoC: TWL4030: Make sure, that the codec is powered on startup Peter Ujfalusi
2009-11-02 12:34         ` [PATCH 5/5] ASoC: TWL4030: Do not modify the APLL_CTL register Peter Ujfalusi
2009-11-02 17:27           ` Mark Brown
2009-11-03 14:05             ` Peter Ujfalusi
2009-11-02 17:28         ` [PATCH 4/5] ASoC: TWL4030: Make sure, that the codec is powered on startup Mark Brown
2009-11-02 17:30       ` [PATCH 3/5] MFD: twl4030-codec: APLL_INFREQ handling in the MFD driver Mark Brown
2009-11-03 13:37         ` Peter Ujfalusi
2009-11-03 13:44           ` Mark Brown
2009-11-03 14:02             ` Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1257165295-9352-1-git-send-email-peter.ujfalusi@nokia.com \
    --to=peter.ujfalusi@nokia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=sameo@linux.intel.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®