From: Joe Perches <joe@perches.com>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: "André Goddard Rosa" <andre.goddard@gmail.com>,
laijs@cn.fujitsu.com, mingo@elte.hu, davem@davemloft.net,
akpm@linux-foundation.org, harvey.harrison@gmail.com,
"linux list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
Date: Mon, 02 Nov 2009 10:29:43 -0800 [thread overview]
Message-ID: <1257186583.28925.47.camel@Joe-Laptop.home> (raw)
In-Reply-To: <20091102181944.GA4880@nowhere>
On Mon, 2009-11-02 at 19:19 +0100, Frederic Weisbecker wrote:
> On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote:
> > Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
> > text data bss dec hex filename
> > 15735 0 8 15743 3d7f lib/vsprintf.o-before
> > 15719 0 8 15727 3d6f lib/vsprintf.o-minus-double-check
> Please add a changelog in your patches, I mean something that
> explain your practical change.
Read the subject and try not to go overboard.
I think the changelog André provided is perfect.
next prev parent reply other threads:[~2009-11-02 18:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-02 17:26 André Goddard Rosa
2009-11-02 18:19 ` Frederic Weisbecker
2009-11-02 18:29 ` Joe Perches [this message]
2009-11-02 19:32 ` Frederic Weisbecker
2009-11-02 19:36 ` Ingo Molnar
2009-11-02 19:44 ` Frederic Weisbecker
2009-11-02 20:00 ` Ingo Molnar
2009-11-02 19:40 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1257186583.28925.47.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=andre.goddard@gmail.com \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=harvey.harrison@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®