Re: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check

[Ingo Molnar <mingo@elte.hu>]

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> On Mon, Nov 02, 2009 at 10:29:43AM -0800, Joe Perches wrote:
> > On Mon, 2009-11-02 at 19:19 +0100, Frederic Weisbecker wrote:
> > > On Mon, Nov 02, 2009 at 03:26:36PM -0200, André Goddard Rosa wrote:
> > > > Subject: [PATCH v2 5/7] vsprintf: reduce code size by avoiding extra check
> > > >    text    data     bss     dec     hex filename
> > > >   15735       0       8   15743    3d7f lib/vsprintf.o-before
> > > >   15719       0       8   15727    3d6f lib/vsprintf.o-minus-double-check
> > > Please add a changelog in your patches, I mean something that
> > > explain your practical change.
> > 
> > Read the subject and try not to go overboard.
> > I think the changelog André provided is perfect.
> 
> 
> It took me some time yesterday to understand how 
> ip6_compressed_string() does its job, hence it took me some time to 
> ensure this patch is safe, hence this reaction for something that 
> didn't seem obvious to me at a first glance.
> 
> But you're right actually, the problem was more in my homework than in 
> the changelog.

Since you wrote the last iteration of that bit and you didnt find it 
trivial i'd strongly suggest the next version of this patch to include a 
more verbose changelog that explains what is being done. There's no harm 
in being verbose about reasons for a change - and there's a lot of harm 
from being too short.

	Ingo