mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, tglx@linutronix.de, x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>, Pavel Machek <pavel@ucw.cz>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Nigel Cunningham <nigel@tuxonice.net>
Subject: [PATCH 2/5] x86, sleep: always save the value of EFER
Date: Fri, 13 Nov 2009 15:28:14 -0800	[thread overview]
Message-ID: <1258154897-6770-3-git-send-email-hpa@zytor.com> (raw)
In-Reply-To: <1258154897-6770-1-git-send-email-hpa@zytor.com>

Always save the value of EFER, regardless of the state of NX.  Since
EFER may not actually exist, use rdmsr_safe() to do so.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Rafael J. Wysocki <rjw@sisk.pl>
Cc: Nigel Cunningham <nigel@tuxonice.net>
---
 arch/x86/kernel/acpi/sleep.c |    9 +++------
 1 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c
index ca93638..c2e4455 100644
--- a/arch/x86/kernel/acpi/sleep.c
+++ b/arch/x86/kernel/acpi/sleep.c
@@ -78,12 +78,9 @@ int acpi_save_state_mem(void)
 #ifndef CONFIG_64BIT
 	store_gdt((struct desc_ptr *)&header->pmode_gdt);
 
-	header->pmode_efer_low = nx_enabled;
-	if (header->pmode_efer_low & 1) {
-		/* This is strange, why not save efer, always? */
-		rdmsr(MSR_EFER, header->pmode_efer_low,
-			header->pmode_efer_high);
-	}
+	header->pmode_efer_low = header->pmode_efer_high = 0;
+	rdmsr_safe(MSR_EFER,
+		   &header->pmode_efer_low, &header->pmode_efer_high);
 #endif /* !CONFIG_64BIT */
 
 	header->pmode_cr0 = read_cr0();
-- 
1.6.2.5


  parent reply	other threads:[~2009-11-13 23:28 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-13 23:28 [RFC] x86: cleanup of NX enabling H. Peter Anvin
2009-11-13 23:28 ` [PATCH 1/5] x86-32: use symbolic constants, safer CPUID when enabling EFER.NX H. Peter Anvin
2009-11-16 22:06   ` [tip:x86/mm] x86-32: Use " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` H. Peter Anvin [this message]
2009-11-14  0:16   ` [PATCH 2/5] x86, sleep: always save the value of EFER Rafael J. Wysocki
2009-11-16 22:06   ` [tip:x86/mm] x86, sleep: Always " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 3/5] x86, pageattr: make set_memory_(x|nx) aware of NX support H. Peter Anvin
2009-11-16 22:07   ` [tip:x86/mm] x86, pageattr: Make " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 4/5] x86, mm: clean up and simplify NX enablement H. Peter Anvin
2009-11-16 22:07   ` [tip:x86/mm] x86, mm: Clean " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 5/5] x86, mm: report state of NX protections during boot H. Peter Anvin
2009-11-16 22:07   ` [tip:x86/mm] x86, mm: Report " tip-bot for Kees Cook
2009-11-14  0:36 ` [PATCH 0/5] x86: cleanup of NX enabling Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258154897-6770-3-git-send-email-hpa@zytor.com \
    --to=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=nigel@tuxonice.net \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®