From: "H. Peter Anvin" <hpa@zytor.com>
To: linux-kernel@vger.kernel.org
Cc: mingo@elte.hu, tglx@linutronix.de, x86@kernel.org,
"H. Peter Anvin" <hpa@zytor.com>,
Huang Ying <ying.huang@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Tejun Heo <tj@kernel.org>, Tim Starling <tstarling@wikimedia.org>,
Hannes Eder <hannes@hanneseder.net>
Subject: [PATCH 3/5] x86, pageattr: make set_memory_(x|nx) aware of NX support
Date: Fri, 13 Nov 2009 15:28:15 -0800 [thread overview]
Message-ID: <1258154897-6770-4-git-send-email-hpa@zytor.com> (raw)
In-Reply-To: <1258154897-6770-1-git-send-email-hpa@zytor.com>
Make set_memory_x/set_memory_nx directly aware of if NX is supported
in the system or not, rather than requiring that every caller assesses
that support independently.
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Huang Ying <ying.huang@intel.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Tim Starling <tstarling@wikimedia.org>
Cc: Hannes Eder <hannes@hanneseder.net>
---
arch/x86/kernel/machine_kexec_32.c | 6 ++----
arch/x86/mm/pageattr.c | 6 ++++++
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/machine_kexec_32.c b/arch/x86/kernel/machine_kexec_32.c
index c1c429d..03657e7 100644
--- a/arch/x86/kernel/machine_kexec_32.c
+++ b/arch/x86/kernel/machine_kexec_32.c
@@ -157,8 +157,7 @@ int machine_kexec_prepare(struct kimage *image)
{
int error;
- if (nx_enabled)
- set_pages_x(image->control_code_page, 1);
+ set_pages_x(image->control_code_page, 1);
error = machine_kexec_alloc_page_tables(image);
if (error)
return error;
@@ -172,8 +171,7 @@ int machine_kexec_prepare(struct kimage *image)
*/
void machine_kexec_cleanup(struct kimage *image)
{
- if (nx_enabled)
- set_pages_nx(image->control_code_page, 1);
+ set_pages_nx(image->control_code_page, 1);
machine_kexec_free_page_tables(image);
}
diff --git a/arch/x86/mm/pageattr.c b/arch/x86/mm/pageattr.c
index dd38bfb..442b8ac 100644
--- a/arch/x86/mm/pageattr.c
+++ b/arch/x86/mm/pageattr.c
@@ -1069,12 +1069,18 @@ EXPORT_SYMBOL(set_memory_array_wb);
int set_memory_x(unsigned long addr, int numpages)
{
+ if (!(__supported_pte_mask & _PAGE_NX))
+ return 0;
+
return change_page_attr_clear(&addr, numpages, __pgprot(_PAGE_NX), 0);
}
EXPORT_SYMBOL(set_memory_x);
int set_memory_nx(unsigned long addr, int numpages)
{
+ if (!(__supported_pte_mask & _PAGE_NX))
+ return 0;
+
return change_page_attr_set(&addr, numpages, __pgprot(_PAGE_NX), 0);
}
EXPORT_SYMBOL(set_memory_nx);
--
1.6.2.5
next prev parent reply other threads:[~2009-11-13 23:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-13 23:28 [RFC] x86: cleanup of NX enabling H. Peter Anvin
2009-11-13 23:28 ` [PATCH 1/5] x86-32: use symbolic constants, safer CPUID when enabling EFER.NX H. Peter Anvin
2009-11-16 22:06 ` [tip:x86/mm] x86-32: Use " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 2/5] x86, sleep: always save the value of EFER H. Peter Anvin
2009-11-14 0:16 ` Rafael J. Wysocki
2009-11-16 22:06 ` [tip:x86/mm] x86, sleep: Always " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` H. Peter Anvin [this message]
2009-11-16 22:07 ` [tip:x86/mm] x86, pageattr: Make set_memory_(x|nx) aware of NX support tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 4/5] x86, mm: clean up and simplify NX enablement H. Peter Anvin
2009-11-16 22:07 ` [tip:x86/mm] x86, mm: Clean " tip-bot for H. Peter Anvin
2009-11-13 23:28 ` [PATCH 5/5] x86, mm: report state of NX protections during boot H. Peter Anvin
2009-11-16 22:07 ` [tip:x86/mm] x86, mm: Report " tip-bot for Kees Cook
2009-11-14 0:36 ` [PATCH 0/5] x86: cleanup of NX enabling Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258154897-6770-4-git-send-email-hpa@zytor.com \
--to=hpa@zytor.com \
--cc=hannes@hanneseder.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=tstarling@wikimedia.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=x86@kernel.org \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®