From: Joe Perches <joe@perches.com>
To: David Wagner <daw-news@taverner.cs.berkeley.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] security/selinux: decrement sizeof size in strncmp
Date: Fri, 13 Nov 2009 19:48:11 -0800 [thread overview]
Message-ID: <1258170491.16857.142.camel@Joe-Laptop.home> (raw)
In-Reply-To: <hdl92e$srv$1@taverner.cs.berkeley.edu>
On Sat, 2009-11-14 at 03:44 +0000, David Wagner wrote:
> I personally don't find
> strncmp(foo, "constant", sizeof("constant")) // first snippet
> to be more readable, auditable, or obviously correct than
> strcmp(foo, "constant"). // second snippet
> Is there a technical basis for arguing that the first
> snippet is better than the second snippet?
I don't think there is.
next prev parent reply other threads:[~2009-11-14 3:48 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-12 7:49 Julia Lawall
2009-11-12 8:16 ` James Morris
2009-11-12 14:53 ` Serge E. Hallyn
2009-11-12 14:57 ` Julia Lawall
2009-11-12 16:21 ` Casey Schaufler
2009-11-12 18:28 ` David Wagner
2009-11-12 21:41 ` James Morris
2009-11-12 21:59 ` Julia Lawall
2009-11-12 23:56 ` David Wagner
2009-11-13 2:11 ` Casey Schaufler
2009-11-13 20:32 ` David Wagner
2009-11-13 21:23 ` Valdis.Kletnieks
2009-11-13 21:26 ` Julia Lawall
2009-11-13 23:08 ` Valdis.Kletnieks
2009-11-14 0:41 ` David Wagner
2009-11-14 5:08 ` Valdis.Kletnieks
2009-11-14 15:22 ` Julia Lawall
2009-11-13 23:06 ` David Wagner
2009-11-14 3:06 ` Casey Schaufler
2009-11-14 3:44 ` David Wagner
2009-11-14 3:48 ` Joe Perches [this message]
2009-11-14 5:12 ` Casey Schaufler
2009-11-14 5:26 ` Joe Perches
2009-11-14 7:20 ` Casey Schaufler
2009-11-15 7:45 ` Raja R Harinath
2009-11-15 18:44 ` Casey Schaufler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1258170491.16857.142.camel@Joe-Laptop.home \
--to=joe@perches.com \
--cc=daw-news@taverner.cs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®