mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Anders Larsen <al@alarsen.net>
To: Anonymous <aim0shei@lavabit.com>
Cc: "André Goddard Rosa" <andre.goddard@gmail.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/12] string: factorize skip_spaces and export it to be generally available
Date: Sun, 15 Nov 2009 22:51:30 +0100	[thread overview]
Message-ID: <1258321890l.9645l.1l@oscar.alarsen.net> (raw)
In-Reply-To: <20091115200215.GA25351@machine> (from aim0shei@lavabit.com on Sun Nov 15 21:02:15 2009)

On 2009-11-15 21:02:15, Anonymous wrote:
> On Sun, Nov 15, 2009 at 08:33:29PM +0100, Anders Larsen wrote:
> > On 2009-11-15 08:15:03, André Goddard Rosa wrote:
> > >+char *skip_spaces(const char *str)
> > >+{
> > >+	while (isspace(*str))
> > >+		++str;
> > >+	return (char *)str;
> > >+}
> >> Is there a good reason why the parameter 'str' is declared 'const'
> > when skip_spaces() returns a non-const pointer into str ?
> >Declaring return value as const won't let us modificate string after
> skipping spaces. Declaring parameter as non-const won't let us
> giving (const char *) to this function. So i think it is ok.

skip_spaces() _implicitly_ casts away the 'const' of the parameter,
which may come as a (nasty) surprise to users of the function.

Consider this (contrieved and buggy) example:

	const char* my_string = " do not modify me! ";
	char* result = strcat(skip_spaces(my_string, "boom!"));

The proposed implementation of skip_spaces() effectively prevents
the compiler from catching this obvious bug.

Cheers
Anders

       reply	other threads:[~2009-11-15 21:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20091115200215.GA25351@machine>
2009-11-15 21:51 ` Anders Larsen [this message]
2009-11-16 12:21   ` André Goddard Rosa
2009-11-14  7:11 [PATCH v5 00/12] introduce skip_spaces(), reducing code size plus some clean-ups André Goddard Rosa
2009-11-14  7:11 ` [PATCH v5 10/12] string: factorize skip_spaces and export it to be generally available André Goddard Rosa
2009-11-15 19:33   ` Anders Larsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1258321890l.9645l.1l@oscar.alarsen.net \
    --to=al@alarsen.net \
    --cc=aim0shei@lavabit.com \
    --cc=akpm@linux-foundation.org \
    --cc=andre.goddard@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®