From: "André Goddard Rosa" <andre.goddard@gmail.com>
To: Anders Larsen <al@alarsen.net>
Cc: Anonymous <aim0shei@lavabit.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 10/12] string: factorize skip_spaces and export it to be generally available
Date: Mon, 16 Nov 2009 10:21:48 -0200 [thread overview]
Message-ID: <b8bf37780911160421s3b79424doe82417f330414d72@mail.gmail.com> (raw)
In-Reply-To: <1258321890l.9645l.1l@oscar.alarsen.net>
Hi, Anders!
On Sun, Nov 15, 2009 at 7:51 PM, Anders Larsen <al@alarsen.net> wrote:
> On 2009-11-15 21:02:15, Anonymous wrote:
>>
>> On Sun, Nov 15, 2009 at 08:33:29PM +0100, Anders Larsen wrote:
>> > On 2009-11-15 08:15:03, André Goddard Rosa wrote:
>> > >+char *skip_spaces(const char *str)
>> > >+{
>> > >+ while (isspace(*str))
>> > >+ ++str;
>> > >+ return (char *)str;
>> > >+}
>> >> Is there a good reason why the parameter 'str' is declared 'const'
>> > when skip_spaces() returns a non-const pointer into str ?
>> >Declaring return value as const won't let us modificate string after
>> skipping spaces. Declaring parameter as non-const won't let us
>> giving (const char *) to this function. So i think it is ok.
>
> skip_spaces() _implicitly_ casts away the 'const' of the parameter,
> which may come as a (nasty) surprise to users of the function.
>
> Consider this (contrieved and buggy) example:
>
> const char* my_string = " do not modify me! ";
> char* result = strcat(skip_spaces(my_string, "boom!"));
>
> The proposed implementation of skip_spaces() effectively prevents
> the compiler from catching this obvious bug.
>
I agree with the above comment. It's possible to make it differently
char* skip_spaces(char *),
but it's necessary to change many of its callers at the same time:
CC lib/argv_split.o
lib/argv_split.c: In function ‘count_argc’:
lib/argv_split.c:24: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
lib/argv_split.c: In function ‘argv_split’:
lib/argv_split.c:78: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
...
CC lib/vsprintf.o
lib/vsprintf.c: In function ‘vsscanf’:
lib/vsprintf.c:1737: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
lib/vsprintf.c:1738: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
lib/vsprintf.c:1808: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
lib/vsprintf.c:1850: warning: passing argument 1 of ‘skip_spaces’
discards qualifiers from pointer target type
include/linux/string.h:65: note: expected ‘char *’ but argument is of
type ‘const char *’
There are other functions following the same pattern presently:
char *strstr(const char *haystack, const char *needle);
char *strchr(const char *s, int c);
char *strrchr(const char *s, int c);
on both glibc and the kernel.
Thanks,
André
next prev parent reply other threads:[~2009-11-16 12:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20091115200215.GA25351@machine>
2009-11-15 21:51 ` Anders Larsen
2009-11-16 12:21 ` André Goddard Rosa [this message]
2009-11-14 7:11 [PATCH v5 00/12] introduce skip_spaces(), reducing code size plus some clean-ups André Goddard Rosa
2009-11-14 7:11 ` [PATCH v5 10/12] string: factorize skip_spaces and export it to be generally available André Goddard Rosa
2009-11-15 19:33 ` Anders Larsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b8bf37780911160421s3b79424doe82417f330414d72@mail.gmail.com \
--to=andre.goddard@gmail.com \
--cc=aim0shei@lavabit.com \
--cc=akpm@linux-foundation.org \
--cc=al@alarsen.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®