* [PATCH] USB: ftdi_sio: fix initialisation of latency timeout
@ 2009-11-22 20:25 Johan Hovold
0 siblings, 0 replies; only message in thread
From: Johan Hovold @ 2009-11-22 20:25 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Alan Cox, linux-usb, linux-kernel, Johan Hovold
Latency timeout was read but never stored on port probe. When
ASYNC_LOW_LATENCY was cleared the device timeout would get set to 0
rather than the default 16ms.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
---
drivers/usb/serial/ftdi_sio.c | 9 +++++----
1 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/serial/ftdi_sio.c b/drivers/usb/serial/ftdi_sio.c
index 9c60d6d..dd130f7 100644
--- a/drivers/usb/serial/ftdi_sio.c
+++ b/drivers/usb/serial/ftdi_sio.c
@@ -1150,7 +1150,6 @@ static int read_latency_timer(struct usb_serial_port *port)
unsigned short latency = 0;
int rv = 0;
-
dbg("%s", __func__);
rv = usb_control_msg(udev,
@@ -1163,8 +1162,9 @@ static int read_latency_timer(struct usb_serial_port *port)
if (rv < 0) {
dev_err(&port->dev, "Unable to read latency timer: %i\n", rv);
return -EIO;
- }
- return latency;
+ } else
+ priv->latency = latency;
+ return rv;
}
static int get_serial_info(struct usb_serial_port *port,
@@ -1551,7 +1551,8 @@ static int ftdi_sio_port_probe(struct usb_serial_port *port)
ftdi_determine_type(port);
ftdi_set_max_packet_size(port);
- read_latency_timer(port);
+ if (read_latency_timer(port) < 0)
+ priv->latency = 16;
create_sysfs_attrs(port);
return 0;
}
--
1.6.5.3
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-11-22 20:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-22 20:25 [PATCH] USB: ftdi_sio: fix initialisation of latency timeout Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®