mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dist-devel@blackfin.uclinux.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 4/8] Blackfin: work around testset anomaly 05000477
Date: Wed, 25 Nov 2009 16:39:03 -0500	[thread overview]
Message-ID: <1259185147-31999-5-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1259185147-31999-1-git-send-email-vapier@gentoo.org>

Ironically, the atomic testset instruction cannot be interrupted else it
will produce incorrect results.  So disable interrupts to help it out.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 arch/blackfin/mach-bf561/atomic.S |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/arch/blackfin/mach-bf561/atomic.S b/arch/blackfin/mach-bf561/atomic.S
index 0261a5e..f99f174 100644
--- a/arch/blackfin/mach-bf561/atomic.S
+++ b/arch/blackfin/mach-bf561/atomic.S
@@ -19,6 +19,16 @@
 	\reg\().h = _corelock;
 .endm
 
+.macro safe_testset addr:req, scratch:req
+#if ANOMALY_05000477
+	cli \scratch;
+	testset (\addr);
+	sti \scratch;
+#else
+	testset (\addr);
+#endif
+.endm
+
 /*
  * r0 = address of atomic data to flush and invalidate (32bit).
  *
@@ -33,7 +43,7 @@ ENTRY(_get_core_lock)
 	cli r0;
 	coreslot_loadaddr p0;
 .Lretry_corelock:
-	testset (p0);
+	safe_testset p0, r2;
 	if cc jump .Ldone_corelock;
 	SSYNC(r2);
 	jump .Lretry_corelock
@@ -56,7 +66,7 @@ ENTRY(_get_core_lock_noflush)
 	cli r0;
 	coreslot_loadaddr p0;
 .Lretry_corelock_noflush:
-	testset (p0);
+	safe_testset p0, r2;
 	if cc jump .Ldone_corelock_noflush;
 	SSYNC(r2);
 	jump .Lretry_corelock_noflush
-- 
1.6.5.3


  parent reply	other threads:[~2009-11-25 21:41 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 21:38 [PATCH 0/8] Blackfin fixes for 2.6.32 Mike Frysinger
2009-11-25 21:39 ` [PATCH 1/8] Blackfin: fix suspend/resume failure with some on-chip ROMs Mike Frysinger
2009-11-25 21:39 ` [PATCH 2/8] Blackfin: fix cache Kconfig typo Mike Frysinger
2009-11-25 21:39 ` [PATCH 3/8] Blackfin: update anomaly lists Mike Frysinger
2009-11-25 21:39 ` Mike Frysinger [this message]
2009-11-25 21:39 ` [PATCH 5/8] Blackfin: check for anomaly 05000475 Mike Frysinger
2009-11-25 21:39 ` [PATCH 6/8] Blackfin: fix typo in ptrace poking Mike Frysinger
2009-11-25 21:39 ` [PATCH 7/8] Blackfin: fix memset in smp_send_reschedule() and -stop() Mike Frysinger
2009-11-25 21:39 ` [PATCH 8/8] Blackfin: fix SMP build error in start_thread() Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259185147-31999-5-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®