mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: uclinux-dist-devel@blackfin.uclinux.org
Cc: linux-kernel@vger.kernel.org, Roel Kluin <roel.kluin@gmail.com>
Subject: [PATCH 7/8] Blackfin: fix memset in smp_send_reschedule() and -stop()
Date: Wed, 25 Nov 2009 16:39:06 -0500	[thread overview]
Message-ID: <1259185147-31999-8-git-send-email-vapier@gentoo.org> (raw)
In-Reply-To: <1259185147-31999-1-git-send-email-vapier@gentoo.org>

From: Roel Kluin <roel.kluin@gmail.com>

To set zeroes the sizeof the struct should be used rather
than sizeof the pointer, kzalloc does that.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 arch/blackfin/mach-common/smp.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/blackfin/mach-common/smp.c b/arch/blackfin/mach-common/smp.c
index d98585f..d92b168 100644
--- a/arch/blackfin/mach-common/smp.c
+++ b/arch/blackfin/mach-common/smp.c
@@ -276,10 +276,9 @@ void smp_send_reschedule(int cpu)
 	if (cpu_is_offline(cpu))
 		return;
 
-	msg = kmalloc(sizeof(*msg), GFP_ATOMIC);
+	msg = kzalloc(sizeof(*msg), GFP_ATOMIC);
 	if (!msg)
 		return;
-	memset(msg, 0, sizeof(msg));
 	INIT_LIST_HEAD(&msg->list);
 	msg->type = BFIN_IPI_RESCHEDULE;
 
@@ -305,10 +304,9 @@ void smp_send_stop(void)
 	if (cpus_empty(callmap))
 		return;
 
-	msg = kmalloc(sizeof(*msg), GFP_ATOMIC);
+	msg = kzalloc(sizeof(*msg), GFP_ATOMIC);
 	if (!msg)
 		return;
-	memset(msg, 0, sizeof(msg));
 	INIT_LIST_HEAD(&msg->list);
 	msg->type = BFIN_IPI_CPU_STOP;
 
-- 
1.6.5.3


  parent reply	other threads:[~2009-11-25 21:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-25 21:38 [PATCH 0/8] Blackfin fixes for 2.6.32 Mike Frysinger
2009-11-25 21:39 ` [PATCH 1/8] Blackfin: fix suspend/resume failure with some on-chip ROMs Mike Frysinger
2009-11-25 21:39 ` [PATCH 2/8] Blackfin: fix cache Kconfig typo Mike Frysinger
2009-11-25 21:39 ` [PATCH 3/8] Blackfin: update anomaly lists Mike Frysinger
2009-11-25 21:39 ` [PATCH 4/8] Blackfin: work around testset anomaly 05000477 Mike Frysinger
2009-11-25 21:39 ` [PATCH 5/8] Blackfin: check for anomaly 05000475 Mike Frysinger
2009-11-25 21:39 ` [PATCH 6/8] Blackfin: fix typo in ptrace poking Mike Frysinger
2009-11-25 21:39 ` Mike Frysinger [this message]
2009-11-25 21:39 ` [PATCH 8/8] Blackfin: fix SMP build error in start_thread() Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1259185147-31999-8-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    --cc=uclinux-dist-devel@blackfin.uclinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®