* [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah)
@ 2023-07-13 7:46 Minjie Du
2023-07-13 7:52 ` Jiri Slaby
2023-07-13 7:52 ` Jiri Slaby
0 siblings, 2 replies; 3+ messages in thread
From: Minjie Du @ 2023-07-13 7:46 UTC (permalink / raw)
To: Jiri Slaby, Nick Kossifidis, Luis Chamberlain, Kalle Valo,
open list:ATHEROS ATH5K WIRELESS DRIVER, open list
Cc: opensource.kernel, Minjie Du
debugfs_create_file() will return early if phydir is an error
pointer, so an extra error check is not needed.
Signed-off-by: Minjie Du <duminjie@vivo.com>
---
drivers/net/wireless/ath/ath5k/debug.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
index 4b41160e5..ec130510a 100644
--- a/drivers/net/wireless/ath/ath5k/debug.c
+++ b/drivers/net/wireless/ath/ath5k/debug.c
@@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
ah->debug.level = ath5k_debug;
phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
- if (!phydir)
- return;
debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
--
2.39.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah)
2023-07-13 7:46 [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah) Minjie Du
@ 2023-07-13 7:52 ` Jiri Slaby
2023-07-13 7:52 ` Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2023-07-13 7:52 UTC (permalink / raw)
To: Minjie Du, Nick Kossifidis, Luis Chamberlain, Kalle Valo,
open list:ATHEROS ATH5K WIRELESS DRIVER, open list
Cc: opensource.kernel
The subject should be:
wifi: ath5k: remove parameter check in ath5k_debug_init_device()
I believe this is documented in SubmittingPatches.
On 13. 07. 23, 9:46, Minjie Du wrote:
> debugfs_create_file() will return early if phydir is an error
> pointer, so an extra error check is not needed.
It would be worth noting that the check is actually wrong.
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
> drivers/net/wireless/ath/ath5k/debug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 4b41160e5..ec130510a 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
> ah->debug.level = ath5k_debug;
>
> phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
> - if (!phydir)
> - return;
>
> debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
> debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah)
2023-07-13 7:46 [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah) Minjie Du
2023-07-13 7:52 ` Jiri Slaby
@ 2023-07-13 7:52 ` Jiri Slaby
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Slaby @ 2023-07-13 7:52 UTC (permalink / raw)
To: Minjie Du, Nick Kossifidis, Luis Chamberlain, Kalle Valo,
open list:ATHEROS ATH5K WIRELESS DRIVER, open list
Cc: opensource.kernel
On 13. 07. 23, 9:46, Minjie Du wrote:
> debugfs_create_file() will return early if phydir is an error
> pointer, so an extra error check is not needed.
>
> Signed-off-by: Minjie Du <duminjie@vivo.com>
> ---
And also: this is a v3 without a changelog.
> drivers/net/wireless/ath/ath5k/debug.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath5k/debug.c b/drivers/net/wireless/ath/ath5k/debug.c
> index 4b41160e5..ec130510a 100644
> --- a/drivers/net/wireless/ath/ath5k/debug.c
> +++ b/drivers/net/wireless/ath/ath5k/debug.c
> @@ -982,8 +982,6 @@ ath5k_debug_init_device(struct ath5k_hw *ah)
> ah->debug.level = ath5k_debug;
>
> phydir = debugfs_create_dir("ath5k", ah->hw->wiphy->debugfsdir);
> - if (!phydir)
> - return;
>
> debugfs_create_file("debug", 0600, phydir, ah, &fops_debug);
> debugfs_create_file("registers", 0400, phydir, ah, ®isters_fops);
--
js
suse labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-13 7:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 7:46 [PATCH v3] drivers: wireless: ath5k: remove parameter check in ath5k_debug_init_device(struct ath5k_hw *ah) Minjie Du
2023-07-13 7:52 ` Jiri Slaby
2023-07-13 7:52 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®