* [PATCH] perf events: Remove unused struct perf_event::event_callback
@ 2009-12-03 23:22 Frederic Weisbecker
2009-12-04 8:48 ` Peter Zijlstra
0 siblings, 1 reply; 3+ messages in thread
From: Frederic Weisbecker @ 2009-12-03 23:22 UTC (permalink / raw)
To: Ingo Molnar
Cc: LKML, Frederic Weisbecker, Peter Zijlstra,
Arnaldo Carvalho de Melo, Paul Mackerras
This field might result from an older manual rebasing mistake.
We don't use it.
Reported-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
---
include/linux/perf_event.h | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
index d045e6e..c7f6502 100644
--- a/include/linux/perf_event.h
+++ b/include/linux/perf_event.h
@@ -671,8 +671,6 @@ struct perf_event {
perf_callback_t callback;
- perf_callback_t event_callback;
-
#endif /* CONFIG_PERF_EVENTS */
};
--
1.6.2.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf events: Remove unused struct perf_event::event_callback
2009-12-03 23:22 [PATCH] perf events: Remove unused struct perf_event::event_callback Frederic Weisbecker
@ 2009-12-04 8:48 ` Peter Zijlstra
2009-12-04 21:02 ` Frederic Weisbecker
0 siblings, 1 reply; 3+ messages in thread
From: Peter Zijlstra @ 2009-12-04 8:48 UTC (permalink / raw)
To: Frederic Weisbecker
Cc: Ingo Molnar, LKML, Arnaldo Carvalho de Melo, Paul Mackerras
On Fri, 2009-12-04 at 00:22 +0100, Frederic Weisbecker wrote:
> @@ -671,8 +671,6 @@ struct perf_event {
>
> perf_callback_t callback;
Any chance we can get all of that perf_callback_t ugly gone?
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf events: Remove unused struct perf_event::event_callback
2009-12-04 8:48 ` Peter Zijlstra
@ 2009-12-04 21:02 ` Frederic Weisbecker
0 siblings, 0 replies; 3+ messages in thread
From: Frederic Weisbecker @ 2009-12-04 21:02 UTC (permalink / raw)
To: Peter Zijlstra
Cc: Ingo Molnar, LKML, Arnaldo Carvalho de Melo, Paul Mackerras
On Fri, Dec 04, 2009 at 09:48:10AM +0100, Peter Zijlstra wrote:
> On Fri, 2009-12-04 at 00:22 +0100, Frederic Weisbecker wrote:
>
> > @@ -671,8 +671,6 @@ struct perf_event {
> >
> > perf_callback_t callback;
>
> Any chance we can get all of that perf_callback_t ugly gone?
Sure. We had callback and event_callback.
event_callback is removed in this patch and overflow_handler will
soon replace the callback field.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-04 21:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-12-03 23:22 [PATCH] perf events: Remove unused struct perf_event::event_callback Frederic Weisbecker
2009-12-04 8:48 ` Peter Zijlstra
2009-12-04 21:02 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®