Re: [PATCH 2/2] arm64: dts: qcom: Add Xiaomi 12 Lite 5G (taoyao) DTS

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 2/4/26 12:56 PM, Stanislav Zaikin wrote:
> Xiaomi 12 Lite 5G is a handset released in 2022
> 
> This commit has the following features working:
> - Display (with simple fb)
> - Touchscreen
> - UFS
> - Power and volume buttons
> - Pinctrl
> - RPM Regulators
> - Remoteprocs - wifi, bluetooth
> - USB (Device Mode)
> 
> Signed-off-by: Stanislav Zaikin <zstaseg@gmail.com>
> ---

Hello, this looks good, couple nits

[...]

> +	// S2B is really ebi.lvl but it's there for supply map completeness sake.

/* C-style comments */ are preferred

[...]

> +		/* Mainline video_mem is downstream cvp_mem */

What does that mean? CVP is strongly connected with the video
hardware, but they're not quite the same

> +		real_video_mem: video@8ad00000 {
> +			reg = <0x0 0x8ad00000 0x0 0x500000>;
> +			no-map;
> +		};
> +
> +		ipa_gsi_mem: ipa-gsi@8b710000 {
> +			reg = <0x0 0x8b710000 0x0 0xa000>;
> +			no-map;
> +		};
> +
> +		cdsp_mem: cdsp@9c700000 {
> +			reg = <0x0 0x9c700000 0x0 0x1e00000>;
> +			no-map;
> +		};
> +
> +		ramoops@a9000000 {
> +			compatible = "ramoops";
> +			reg = <0x0 0xa9000000 0x0 0x200000>;
> +			pmsg-size = <0x200000>;
> +			mem-type = <0x02>;

= <2> would be neater

If you have an easy way of modifying the (presumably) downstream-based
image which you use for ramoops, you may want to add ecc-size = <8>
too, so that it's more robust

[...]

> +&tlmm {
> +	gpio-reserved-ranges = <32 2>, <48 4>, <56 4>;

Any chance you know what they're used for? (you can often correlate them
with QUP pinctrl entries, as they're often fingerprint scanner/NFC eSE
connections)

If you do, please sprinkle in some comments, like in x1-crd.dtsi

[...]

> +&usb_1 {
> +	/* USB 2.0 only */
> +	qcom,select-utmi-as-pipe-clk;
> +
> +	dr_mode = "otg";
> +	usb-role-switch;
> +	maximum-speed = "high-speed";
> +	/* Remove USB3 phy */
> +	phys = <&usb_1_hsphy>;
> +	phy-names = "usb2-phy";

Did you check whether that's the case with a ""real"" USB3 Type-C
cable? Does a Type-C dongle with a HDMI/DP output work if you plug it
in when running downstream?

Konrad