mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com,
	mingo@redhat.com, Mathieu Desnoyers <compudj@krystal.dyndns.org>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Fix tracing infrastructure to support multiple includes when defining CREATE_TRACE_POINTS
Date: Mon, 07 Dec 2009 15:49:26 -0500	[thread overview]
Message-ID: <1260218966.3518.4.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <1260218831.3518.3.camel@gandalf.stny.rr.com>

On Mon, 2009-12-07 at 15:47 -0500, Steven Rostedt wrote:

> > 
> > Note this patch also converts the napi_poll tracepoint to a TRACE_EVENT.  This
> > is done so that the TRACE_EVENT fix doesn't break the build, and because its
> > rather pointless I think given the current tracing infrastructure to not have
> > napi_poll be an independent event.
> > 
> > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
> 
> Thanks, I'll give it a test. But because this now touches networking
> code, I need an Acked-by from David Miller before I can pull it in.
> 
> -- Steve
> 
> 
> 
> > 
> > 
> > linux/tracepoint.h   |   45 +++++++++++++++++++++++----------------------
> > trace/define_trace.h |    1 +
> > trace/events/napi.h  |   25 ++++++++++++++++++++++---

Hmm, This really isn't networking code. But still, a patch that changes
the way a networking trace point works, I would rather have an ack.

Thanks,

-- Steve

> > 3 files changed, 46 insertions(+), 25 deletions(-)
> > 
> > diff --git a/include/linux/tracepoint.h b/include/linux/tracepoint.h
> > index 2aac8a8..311abbf 100644
> > --- a/include/linux/tracepoint.h
> > +++ b/include/linux/tracepoint.h
> > @@ -58,28 +58,6 @@ struct tracepoint {
> >  		rcu_read_unlock_sched_notrace();			\
> >  	} while (0)
> >  



  reply	other threads:[~2009-12-07 20:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-02 19:19 Neil Horman
2009-12-03 14:15 ` Steven Rostedt
2009-12-03 19:35   ` Neil Horman
2009-12-03 19:42     ` Steven Rostedt
2009-12-07 20:04     ` Steven Rostedt
2009-12-07 20:18       ` Neil Horman
2009-12-07 20:47         ` Steven Rostedt
2009-12-07 20:49           ` Steven Rostedt [this message]
2009-12-07 20:53             ` Neil Horman
2009-12-14 19:50               ` Neil Horman
2009-12-15 16:08                 ` Neil Horman
2009-12-16  4:13                   ` Steven Rostedt
2009-12-16 11:49                     ` Neil Horman
2009-12-16 16:04                       ` Neil Horman
2009-12-22 18:03                         ` Steven Rostedt
2009-12-23 12:02                           ` Neil Horman
2009-12-23 13:58                             ` Steven Rostedt
2009-12-23 18:36                               ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260218966.3518.4.camel@gandalf.stny.rr.com \
    --to=rostedt@goodmis.org \
    --cc=compudj@krystal.dyndns.org \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®