From: Steven Rostedt <rostedt@goodmis.org>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-kernel@vger.kernel.org, fweisbec@gmail.com,
mingo@redhat.com, Mathieu Desnoyers <compudj@krystal.dyndns.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] Fix tracing infrastructure to support multiple includes when defining CREATE_TRACE_POINTS
Date: Wed, 23 Dec 2009 08:58:33 -0500 [thread overview]
Message-ID: <1261576713.25193.2542.camel@gandalf.stny.rr.com> (raw)
In-Reply-To: <20091223120224.GA6520@hmsreliant.think-freely.org>
On Wed, 2009-12-23 at 07:02 -0500, Neil Horman wrote:
> On Tue, Dec 22, 2009 at 01:03:59PM -0500, Steven Rostedt wrote:
> > On Wed, 2009-12-16 at 11:04 -0500, Neil Horman wrote:
> >
> >
> > > +#if !defined(_TRACE_NAPI_H_) || defined(TRACE_HEADER_MULTI_READ)
> > > #define _TRACE_NAPI_H_
> > >
> >
> > Ug, I'm still getting panics because of this. I found out that it's
> > because napi->dev can be NULL.
> >
> > Here's what I did to solve it:
> Gahhh, you're right, We had to do the same thing in net-next's commit
> f2798eb4e01b095f273f4bf40f511c9d69c0e1da. If you queue to the backlog, the
> backlog napi instance has no net device and so its null. This is exactly the
> right fix.
OK, I'll update the patch and apply it.
But this doesn't need to go into 33 correct. We can let it brew for 34?
-- Steve
next prev parent reply other threads:[~2009-12-23 13:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-02 19:19 Neil Horman
2009-12-03 14:15 ` Steven Rostedt
2009-12-03 19:35 ` Neil Horman
2009-12-03 19:42 ` Steven Rostedt
2009-12-07 20:04 ` Steven Rostedt
2009-12-07 20:18 ` Neil Horman
2009-12-07 20:47 ` Steven Rostedt
2009-12-07 20:49 ` Steven Rostedt
2009-12-07 20:53 ` Neil Horman
2009-12-14 19:50 ` Neil Horman
2009-12-15 16:08 ` Neil Horman
2009-12-16 4:13 ` Steven Rostedt
2009-12-16 11:49 ` Neil Horman
2009-12-16 16:04 ` Neil Horman
2009-12-22 18:03 ` Steven Rostedt
2009-12-23 12:02 ` Neil Horman
2009-12-23 13:58 ` Steven Rostedt [this message]
2009-12-23 18:36 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261576713.25193.2542.camel@gandalf.stny.rr.com \
--to=rostedt@goodmis.org \
--cc=compudj@krystal.dyndns.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®