mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xiaotian Feng <dfeng@redhat.com>
To: linux-acpi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Xiaotian Feng <dfeng@redhat.com>,
	Len Brown <lenb@kernel.org>, Bob Moore <robert.moore@intel.com>,
	Lin Ming <ming.m.lin@intel.com>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	Pavel Machek <pavel@ucw.cz>
Subject: [PATCH -V2] acpi: don't cond_resched if irq is disabled
Date: Thu, 10 Dec 2009 19:56:45 +0800	[thread overview]
Message-ID: <1260446205-16868-1-git-send-email-dfeng@redhat.com> (raw)
In-Reply-To: <20091210100907.GA2446@ucw.cz>

commit 8bd108d adds preemption point after each opcode parse, then
a sleeping function called from invalid context bug was founded
during suspend/resume stage. this was fixed in commit abe1dfa by
don't cond_resched when irq_disabled. But recent commit 138d156 changes
the behaviour to don't cond_resched when in_atomic. This makes the
sleeping function called from invalid context bug happen again, which
is reported in http://lkml.org/lkml/2009/12/1/371.

This patch also fixes http://bugzilla.kernel.org/show_bug.cgi?id=14483

Reported-and-bisected-by: Larry Finger <Larry.Finger@lwfinger.net>
Reported-and-bisected-by: Justin P. Mattock <justinmattock@gmail.com>
Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Cc: Len Brown <lenb@kernel.org>
Cc: Bob Moore <robert.moore@intel.com>
Cc: Lin Ming <ming.m.lin@intel.com>
Cc: Alexey Starikovskiy <astarikovskiy@suse.de>
Cc: Pavel Machek <pavel@ucw.cz>
---
 include/acpi/platform/aclinux.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/acpi/platform/aclinux.h b/include/acpi/platform/aclinux.h
index 9d7febd..0946997 100644
--- a/include/acpi/platform/aclinux.h
+++ b/include/acpi/platform/aclinux.h
@@ -152,7 +152,7 @@ static inline void *acpi_os_acquire_object(acpi_cache_t * cache)
 #include <linux/hardirq.h>
 #define ACPI_PREEMPTION_POINT() \
 	do { \
-		if (!in_atomic_preempt_off()) \
+		if (!in_atomic_preempt_off() && !irqs_disabled()) \
 			cond_resched(); \
 	} while (0)
 
-- 
1.6.5.2


  reply	other threads:[~2009-12-10 11:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-04  4:26 [PATCH] ACPICA: don't cond_resched() when irq_disabled or in_atomic Xiaotian Feng
2009-12-04  5:36 ` Zhang Rui
2009-12-04  5:38   ` Zhang Rui
2009-12-04  6:50 ` Justin Mattock
2009-12-04  7:05   ` Danny Feng
2009-12-04  7:27     ` Justin P. Mattock
2009-12-09  1:54       ` Xiaotian Feng
2009-12-10 10:09 ` Pavel Machek
2009-12-10 11:56   ` Xiaotian Feng [this message]
2009-12-10 12:21     ` [PATCH -V2] acpi: don't cond_resched if irq is disabled Alexey Starikovskiy
2009-12-11  5:46       ` Lin Ming
2009-12-11 11:48         ` Alexey Starikovskiy
2009-12-11 16:15           ` Pavel Machek
2009-12-11 16:25             ` Alexey Starikovskiy
2009-12-11 17:34               ` Pavel Machek
2009-12-28  6:02                 ` Xiaotian Feng
2009-12-28 11:12                   ` Alexey Starikovskiy
2010-01-16  6:44                     ` Len Brown
2009-12-10 17:58   ` [PATCH] ACPICA: don't cond_resched() when irq_disabled or in_atomic Alexey Starikovskiy
2009-12-10 18:18     ` Pavel Machek
2009-12-10 18:37       ` Alexey Starikovskiy
2009-12-10 22:46         ` Justin P. Mattock
2009-12-10 22:54           ` Moore, Robert
2010-01-16  6:46             ` Len Brown
2009-12-11 17:33         ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260446205-16868-1-git-send-email-dfeng@redhat.com \
    --to=dfeng@redhat.com \
    --cc=astarikovskiy@suse.de \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=pavel@ucw.cz \
    --cc=robert.moore@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome