mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Wessel <jason.wessel@windriver.com>
To: torvalds@linux-foundation.org
Cc: linux-kernel@vger.kernel.org,
	kgdb-bugreport@lists.sourceforge.net,
	Roel Kluin <roel.kluin@gmail.com>,
	Jason Wessel <jason.wessel@windriver.com>
Subject: [PATCH 3/9] kgdbts: Read buffer overflow
Date: Fri, 11 Dec 2009 09:36:11 -0600	[thread overview]
Message-ID: <1260545777-8089-4-git-send-email-jason.wessel@windriver.com> (raw)
In-Reply-To: <1260545777-8089-3-git-send-email-jason.wessel@windriver.com>

From: Roel Kluin <roel.kluin@gmail.com>

Prevent write to put_buf[BUFMAX] in kgdb test suite.

If put_buf_cnt was BUFMAX - 1 at the earlier test,
`\0' is written to put_buf[BUFMAX].

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
---
 drivers/misc/kgdbts.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c
index e4ff50b..2ab0492 100644
--- a/drivers/misc/kgdbts.c
+++ b/drivers/misc/kgdbts.c
@@ -712,6 +712,12 @@ static int run_simple_test(int is_get_char, int chr)
 
 	/* End of packet == #XX so look for the '#' */
 	if (put_buf_cnt > 3 && put_buf[put_buf_cnt - 3] == '#') {
+		if (put_buf_cnt >= BUFMAX) {
+			eprintk("kgdbts: ERROR: put buffer overflow on"
+				" '%s' line %i\n", ts.name, ts.idx);
+			put_buf_cnt = 0;
+			return 0;
+		}
 		put_buf[put_buf_cnt] = '\0';
 		v2printk("put%i: %s\n", ts.idx, put_buf);
 		/* Trigger check here */
-- 
1.6.4.rc1


  reply	other threads:[~2009-12-11 15:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-11 15:36 [GIT PULL] kgdb 2.6.33 Jason Wessel
2009-12-11 15:36 ` [PATCH 1/9] kgdb,x86: remove redundant test Jason Wessel
2009-12-11 15:36   ` [PATCH 2/9] kgdb: Read buffer overflow Jason Wessel
2009-12-11 15:36     ` Jason Wessel [this message]
2009-12-11 15:36       ` [PATCH 4/9] kgdb: Replace strstr() by strchr() for single-character needles Jason Wessel
2009-12-11 15:36         ` [PATCH 5/9] kgdb,i386: Fix corner case access to ss with NMI watch dog exception Jason Wessel
2009-12-11 15:36           ` [PATCH 6/9] kgdb: allow for cpu switch when single stepping Jason Wessel
2009-12-11 15:36             ` [PATCH 7/9] kgdb,x86: do not set kgdb_single_step on x86 Jason Wessel
2009-12-11 15:36               ` [PATCH 8/9] kgdb: continue and warn on signal passing from gdb Jason Wessel
2009-12-11 15:36                 ` [PATCH 9/9] kgdb: Always process the whole breakpoint list on activate or deactivate Jason Wessel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1260545777-8089-4-git-send-email-jason.wessel@windriver.com \
    --to=jason.wessel@windriver.com \
    --cc=kgdb-bugreport@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roel.kluin@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®