From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Phil Carmody <ext-phil.2.carmody@nokia.com>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 08/10] driver core: Prevent reference to freed memory on error path
Date: Wed, 23 Dec 2009 11:52:41 -0800 [thread overview]
Message-ID: <1261597963-18323-8-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20091223194955.GB18101@kroah.com>
From: Phil Carmody <ext-phil.2.carmody@nokia.com>
priv is drv->p. So only free drv->p after we've finished using priv.
Found using a static code analysis tool
Signed-off-by: Phil Carmody <ext-phil.2.carmody@nokia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/bus.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/bus.c b/drivers/base/bus.c
index 63c143e..c0c5a43 100644
--- a/drivers/base/bus.c
+++ b/drivers/base/bus.c
@@ -703,9 +703,9 @@ int bus_add_driver(struct device_driver *drv)
return 0;
out_unregister:
+ kobject_put(&priv->kobj);
kfree(drv->p);
drv->p = NULL;
- kobject_put(&priv->kobj);
out_put_bus:
bus_put(bus);
return error;
--
1.6.5.7
next prev parent reply other threads:[~2009-12-23 19:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 19:49 [GIT PATCH] driver core patches for 2.6.33-git Greg KH
2009-12-23 19:52 ` [PATCH 01/10] devtmpfs: Convert dirlock to a mutex Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 02/10] vfs: get_sb_single() - do not pass options twice Greg Kroah-Hartman
2009-12-27 12:36 ` OGAWA Hirofumi
2009-12-30 18:05 ` Kay Sievers
2009-12-30 19:30 ` OGAWA Hirofumi
2009-12-23 19:52 ` [PATCH 03/10] Doc/stable rules: add new cherry-pick logic Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 04/10] Driver core: device_attribute parameters can often be const* Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 05/10] Driver core: bin_attribute " Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 06/10] Driver core: driver_attribute " Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 07/10] Driver-core: Fix bogus 0 error return in device_add() Greg Kroah-Hartman
2009-12-23 19:52 ` Greg Kroah-Hartman [this message]
2009-12-23 19:52 ` [PATCH 09/10] Driver core: export platform_device_register_data as a GPL symbol Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 10/10] devtmpfs: unlock mutex in case of string allocation error Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261597963-18323-8-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=ext-phil.2.carmody@nokia.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®