From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>
Subject: Re: [PATCH 02/10] vfs: get_sb_single() - do not pass options twice
Date: Thu, 31 Dec 2009 04:30:11 +0900 [thread overview]
Message-ID: <87hbr8w98c.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <ac3eb2510912301005g4870332cm63ebb497c9faf9da@mail.gmail.com> (Kay Sievers's message of "Wed, 30 Dec 2009 19:05:58 +0100")
Kay Sievers <kay.sievers@vrfy.org> writes:
> On Sun, Dec 27, 2009 at 13:36, OGAWA Hirofumi
> <hirofumi@mail.parknet.co.jp> wrote:
>>> Filesystem code usually destroys the option buffer while
>>> parsing it. This leads to errors when the same buffer is
>>> passed twice. In case we fill a new superblock do not call
>>> remount.
>
>> This breaks the historical behavior. Several users of get_sb_single() is
>> parse data only on ->remount_fs. Well, ok, I like new behavior actually.
>> But we need to convert to new behavior such users.
>>
>> I've listed all possibly affected users up (if I'm not missing). This
>> means, using both data on ->fill_super and ->remount_fs is devtmpfs
>> only. And capifs, usbfs, devpts would be needed the patch.
>
> Hmm, these filesystem are probably not going to overwrite their own
> default options with their own special parameters to parse when they
> allocate their superblock. That would be pretty weird, wouldn't it?
> Seems they currently don't even pass "data" pointer around at that
> time.
Oops, I was missing that those all fs was using kern_mount(). Sorry for
noise.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2009-12-30 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-23 19:49 [GIT PATCH] driver core patches for 2.6.33-git Greg KH
2009-12-23 19:52 ` [PATCH 01/10] devtmpfs: Convert dirlock to a mutex Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 02/10] vfs: get_sb_single() - do not pass options twice Greg Kroah-Hartman
2009-12-27 12:36 ` OGAWA Hirofumi
2009-12-30 18:05 ` Kay Sievers
2009-12-30 19:30 ` OGAWA Hirofumi [this message]
2009-12-23 19:52 ` [PATCH 03/10] Doc/stable rules: add new cherry-pick logic Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 04/10] Driver core: device_attribute parameters can often be const* Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 05/10] Driver core: bin_attribute " Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 06/10] Driver core: driver_attribute " Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 07/10] Driver-core: Fix bogus 0 error return in device_add() Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 08/10] driver core: Prevent reference to freed memory on error path Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 09/10] Driver core: export platform_device_register_data as a GPL symbol Greg Kroah-Hartman
2009-12-23 19:52 ` [PATCH 10/10] devtmpfs: unlock mutex in case of string allocation error Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87hbr8w98c.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=gregkh@suse.de \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®