From: James Bottomley <James.Bottomley@suse.de>
To: Stefani Seibold <stefani@seibold.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: [PATCH] libsrp: fix compile failure
Date: Wed, 30 Dec 2009 13:21:06 -0600 [thread overview]
Message-ID: <1262200866.2749.226.camel@mulgrave.site> (raw)
commit 45465487897a1c6d508b14b904dc5777f7ec7e04
Author: Stefani Seibold <stefani@seibold.net>
Date: Mon Dec 21 14:37:26 2009 -0800
kfifo: move struct kfifo in place
Caused a compile failure in ibmvscsitgt.c because it changed a pointer
to kfifo in the libsrp.h structure to a direct inclusion without
including <linux/kfifo.h>. The fix is simple, just add the include, but
how did this happen? This change, introduced at -rc2, hardly looks like
a bug fix, and it clearly didn't go through linux-next, which would have
picked up this compile failure (it only occurs on ppc because of the ibm
virtual scsi target).
James
---
diff --git a/include/scsi/libsrp.h b/include/scsi/libsrp.h
index 07e3add..f4105c9 100644
--- a/include/scsi/libsrp.h
+++ b/include/scsi/libsrp.h
@@ -2,6 +2,7 @@
#define __LIBSRP_H__
#include <linux/list.h>
+#include <linux/kfifo.h>
#include <scsi/scsi_cmnd.h>
#include <scsi/scsi_host.h>
#include <scsi/srp.h>
next reply other threads:[~2009-12-30 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 19:21 James Bottomley [this message]
2009-12-30 19:33 ` Linus Torvalds
2009-12-30 19:55 ` James Bottomley
2010-01-04 15:21 ` Jiri Kosina
2010-01-04 17:22 ` James Bottomley
2010-01-04 17:35 ` Alan Cox
2010-01-04 19:24 ` Stefani Seibold
2010-01-04 19:37 ` James Bottomley
2010-01-04 22:36 ` Alan Cox
2010-01-04 21:12 ` Jiri Kosina
2010-01-04 21:35 ` Andrew Morton
2010-01-04 22:00 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262200866.2749.226.camel@mulgrave.site \
--to=james.bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stefani@seibold.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®