mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 1/9] bitops: rename for_each_bit to for_each_set_bit
Date: Mon, 01 Feb 2010 09:25:39 -0800	[thread overview]
Message-ID: <1265045139.25140.284.camel@Joe-Laptop.home> (raw)
In-Reply-To: <1265037040-23413-1-git-send-email-akinobu.mita@gmail.com>

On Tue, 2010-02-02 at 00:10 +0900, Akinobu Mita wrote:
> Rename for_each_bit to for_each_set_bit in the kernel source tree.

I preferred the for_each_bit because it gives some
naming consistency.

These look for set bits:

        find_first_bit
        find_next_bit
        find_last_bit
        
These look for unset bits:

        find_first_zero_bit
        find_next_zero_bit

I think there should be 3 macros named:
        for_each_bit
        for_each_zero_bit
        for_every_bit

and maybe there's a use for:
        find_last_zero_bit

I think the macro definition should be located
near these other functions in bitops.h and not
placed somewhat randomly near the top of the file.



  parent reply	other threads:[~2010-02-01 17:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-01 15:10 Akinobu Mita
2010-02-01 15:10 ` [PATCH 2/9] sgi-gru: Use for_each_set_bit Akinobu Mita
2010-02-01 15:10 ` [PATCH 3/9] sched: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 4/9] bitmap: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 5/9] phonet: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 6/9] intel-iommu: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 7/9] infiniband: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 8/9] atm: " Akinobu Mita
2010-02-01 15:10 ` [PATCH 9/9] hpet: " Akinobu Mita
2010-02-01 17:25 ` Joe Perches [this message]
2010-03-05  4:57 ` [PATCH 1/9] bitops: rename for_each_bit to for_each_set_bit Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1265045139.25140.284.camel@Joe-Laptop.home \
    --to=joe@perches.com \
    --cc=akinobu.mita@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®