Re: [PATCH] isp1760: Flush the D-cache for the pipe-in transfer buffers

[Catalin Marinas <catalin.marinas@arm.com>]

On Tue, 2010-02-02 at 12:08 +0000, Sebastian Andrzej Siewior wrote:
> * Catalin Marinas | 2010-02-02 11:11:35 [+0000]:
> 
> >When the HDC driver writes the data to the transfer buffers it pollutes
> >the D-cache (unlike DMA drivers where the device writes the data). If
> >the corresponding pages get mapped into user space, there are no
> >additional cache flushing operations performed and this causes random
> >user space faults on architectures with separate I and D caches
> >(Harvard) or those with aliasing D-cache.
> 
> After looking through lib/scatterlist.c it uses
> #include <linux/highmem.h>
> 
> and
> 
> flush_kernel_dcache_page().
> Wouldn't this do the job here as well?

The documentation implies that this is to be used only with pages
obtained with kmap(), which doesn't seem to be the case here. On some
ARM processors it isn't even implemented (kunmap does the necessary
flushing).

-- 
Catalin