[PATCH 6/7] edac: mpc85xx fsb ecc

[PATCH 6/7] edac: mpc85xx fsb ecc

[dougthompson]

From: Konstantin Olifer <kolifer@gmail.com>

Patch is for Kernel 2.6.33. e752x_edac suppose that fsb ECC exist, for example, on
Celeron + 3100. That is wrong. 
ECC FSB supported only on Xeon for our vision (www.setdsp.ru) and datasheet from developer intel www. 
Fixed.


Signed-off-by:  Konstantin Olifer <kolifer@gmail.com>
Signed-off-by:  Doug Thompson <dougthompson@xmission.com>
---
 e752x_edac.c |   10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

Index: linux-2.6.33-rc4/drivers/edac/e752x_edac.c
===================================================================
--- linux-2.6.33-rc4.orig/drivers/edac/e752x_edac.c	2010-01-12 23:26:07.000000000 -0700
+++ linux-2.6.33-rc4/drivers/edac/e752x_edac.c	2010-01-12 23:26:13.000000000 -0700
@@ -1073,10 +1073,7 @@ fail:
 
 /* Setup system bus parity mask register.
  * Sysbus parity supported on:
- *   e7320/e7520/e7525 + Xeon
- *   i3100 + Xeon/Celeron
- * Sysbus parity not supported on:
- *   i3100 + Pentium M/Celeron M/Core Duo/Core2 Duo
+ * e7320/e7520/e7525 + Xeon
  */
 static void e752x_init_sysbus_parity_mask(struct e752x_pvt *pvt)
 {
@@ -1087,10 +1084,7 @@ static void e752x_init_sysbus_parity_mas
 	/* Allow module parameter override, else see if CPU supports parity */
 	if (sysbus_parity != -1) {
 		enable = sysbus_parity;
-	} else if (cpu_id[0] &&
-		   ((strstr(cpu_id, "Pentium") && strstr(cpu_id, " M ")) ||
-		    (strstr(cpu_id, "Celeron") && strstr(cpu_id, " M ")) ||
-		    (strstr(cpu_id, "Core") && strstr(cpu_id, "Duo")))) {
+	} else if (cpu_id[0] && !strstr(cpu_id, "Xeon")) {
 		e752x_printk(KERN_INFO, "System Bus Parity not "
 			     "supported by CPU, disabling\n");
 		enable = 0;

Re: [PATCH 6/7] edac: mpc85xx fsb ecc

[Peter Tyser]

Hi Doug and Konstantin,

On Wed, 2010-02-03 at 23:46 -0700, dougthompson@xmission.com wrote:
> From: Konstantin Olifer <kolifer@gmail.com>
> 
> Patch is for Kernel 2.6.33. e752x_edac suppose that fsb ECC exist, for example, on
> Celeron + 3100. That is wrong. 
> ECC FSB supported only on Xeon for our vision (www.setdsp.ru) and datasheet from developer intel www. 
> Fixed.
> Signed-off-by:  Konstantin Olifer <kolifer@gmail.com>
> Signed-off-by:  Doug Thompson <dougthompson@xmission.com>
> ---
>  e752x_edac.c |   10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)

It looks like 6/7 and 7/7 in this series have the wrong subject/title.
Patches 6 and 7 are for the e752x instead of the mpc85xx.

When changing the subjects, it might be nice to change this commit
message to something more straightforward such as:
"FSB parity is only supported on the Xeon processor.  Previously it was
incorrectly enabled for the Celeron as well."

Best,
Peter

Re: [PATCH 6/7] edac: mpc85xx fsb ecc

[Doug Thompson]

--- On Thu, 2/4/10, Peter Tyser <ptyser@xes-inc.com> wrote:

> From: Peter Tyser <ptyser@xes-inc.com>
> Subject: Re: [PATCH 6/7] edac: mpc85xx fsb ecc
> To: dougthompson@xmission.com
> Cc: kolifer@gmail.com, akpm@linux-foundation.org, bluesmoke-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
> Date: Thursday, February 4, 2010, 10:22 AM
> Hi Doug and Konstantin,
> 
> On Wed, 2010-02-03 at 23:46 -0700, dougthompson@xmission.com
> wrote:
> > From: Konstantin Olifer <kolifer@gmail.com>
> > 
> > Patch is for Kernel 2.6.33. e752x_edac suppose that
> fsb ECC exist, for example, on
> > Celeron + 3100. That is wrong. 
> > ECC FSB supported only on Xeon for our vision
> (www.setdsp.ru) and datasheet from developer intel www. 
> > Fixed.
> > Signed-off-by:  Konstantin Olifer <kolifer@gmail.com>
> > Signed-off-by:  Doug Thompson <dougthompson@xmission.com>
> > ---
> >  e752x_edac.c |   10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> It looks like 6/7 and 7/7 in this series have the wrong
> subject/title.
> Patches 6 and 7 are for the e752x instead of the mpc85xx.

my bad while I was constructing the titles. missed the driver name

thanks andrew for fixing that


doug t