* [WARNING] mxc_w1_probe should not be __init modified
@ 2010-02-12 10:42 Alberto Panizzo
2010-02-12 11:01 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Alberto Panizzo @ 2010-02-12 10:42 UTC (permalink / raw)
To: Sascha Hauer; +Cc: Evgeniy Polyakov, linux-kernel, linux-arm-kernel
Today linux-next build, report this:
WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
The variable mxc_w1_driver references
the function __init mxc_w1_probe()
If the reference is valid then annotate the
variable with __init* or __refdata (see linux/init.h) or name the variable:
*_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
I don't know if should be modified with __devinit instead or nothing at all.
Best regards.
--
Alberto!
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [WARNING] mxc_w1_probe should not be __init modified
2010-02-12 10:42 [WARNING] mxc_w1_probe should not be __init modified Alberto Panizzo
@ 2010-02-12 11:01 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2010-02-12 11:01 UTC (permalink / raw)
To: Alberto Panizzo
Cc: Sascha Hauer, Evgeniy Polyakov, linux-kernel, linux-arm-kernel
Hello,
On Fri, Feb 12, 2010 at 11:42:28AM +0100, Alberto Panizzo wrote:
> Today linux-next build, report this:
>
> WARNING: drivers/w1/masters/built-in.o(.data+0x0): Section mismatch in reference from the variable mxc_w1_driver to the function .init.text:mxc_w1_probe()
> The variable mxc_w1_driver references
> the function __init mxc_w1_probe()
> If the reference is valid then annotate the
> variable with __init* or __refdata (see linux/init.h) or name the variable:
> *_template, *_timer, *_sht, *_ops, *_probe, *_probe_one, *_console,
>
>
> I don't know if should be modified with __devinit instead or nothing at all.
Yes it should use __devinit. If you need a reason, try
cd /sys/bus/platform/drivers/mxc_w1
echo -n mxc_w1.0 > unbind
echo -n mxc_w1.0 > bind
While at it, mxc_w1_remove can be moved to devexit.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-12 11:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-02-12 10:42 [WARNING] mxc_w1_probe should not be __init modified Alberto Panizzo
2010-02-12 11:01 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®